Skip to content

fix(install): don't require the GitHub API when RAILWAY_VERSION is pinned #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krushiraj wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −9
Open

fix(install): don't require the GitHub API when RAILWAY_VERSION is pinned #1031

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,19 +408,26 @@ RAILWAY_PATH_MARKER_END="# <<< railway initialize <<<"
SHELL_STARTUP_FILE=""
SHELL_STARTUP_ACTION=""

DEFAULT_VERSION=$(curl -s https://api.github.com/repos/railwayapp/cli/releases/latest | grep -o '"tag_name":[[:space:]]*"v[^"]*"' | cut -d'"' -f4 | cut -c2-)
# Resolve the version to install, asking GitHub for the latest release only
# when the caller hasn't pinned one. Called after argument parsing so that a
# pinned install, --help and --uninstall all work without reaching the GitHub
# API — an API rate limit shouldn't be able to fail an install of a version the
# caller already named.
resolve_version() {
if [ -n "${RAILWAY_VERSION-}" ]; then
return 0
fi

if [ -z "$DEFAULT_VERSION" ]; then
error "Failed to fetch latest version from GitHub"
exit 1
fi
RAILWAY_VERSION=$(curl -s https://api.github.com/repos/railwayapp/cli/releases/latest | grep -o '"tag_name":[[:space:]]*"v[^"]*"' | cut -d'"' -f4 | cut -c2-)

if [ -z "$RAILWAY_VERSION" ]; then
error "Failed to fetch latest version from GitHub"
info "Set RAILWAY_VERSION=<x.y.z> to install a specific version without querying the API."
exit 1
fi
}

# defaults
if [ -z "${RAILWAY_VERSION-}" ]; then
RAILWAY_VERSION="$DEFAULT_VERSION"
fi

if [ -z "${RAILWAY_PLATFORM-}" ]; then
PLATFORM="$(detect_platform)"
fi
Expand Down Expand Up @@ -1032,6 +1039,8 @@ if [ "$HELP" = 1 ]; then
exit 0
fi

resolve_version

RAILWAY_UPGRADE_AGENT=0

if [ "$AGENTS" = 1 ] && has railway; then
Expand Down