feat(@convex-dev/better-auth): migrate to better-auth 1.6 (pr323)#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add bun/npm/pnpm patches for
@convex-dev/better-auth@0.11.4that bring in thebetter-auth1.6 migration from upstream PR get-convex/better-auth#323.The patch bumps the peer range to
>=1.6.0 <1.7.0, accepts the newWhere.modefield in adapter validators (soapi.adapter.findOnestops throwingArgumentValidationError), passesasResponse: falseat 7 internal plugin endpoint call sites (6 inconvex, 1 incross-domain) so 1.6's flippedshouldReturnResponsedefault doesn't turn{ token }intoundefined(JWT cookies becoming the literal string"undefined") or crashsetSessionCookieon cross-domain, and silences theoidcProviderdeprecation warning with__skipDeprecationWarning.Built by diffing the
@convex-dev/better-auth@0.11.4npm tarball against a cleantscbuild of the PR tip ate17d80e. Excludes test files, example lockfiles, andCHANGELOG.md.package.jsonversion field left at0.11.4(not bumped to0.12.0) so the installed tag matches what tooling reads; only thebetter-authpeer range is changed there. Verified withpatch -p1 --dry-runagainst a freshnpm pack @convex-dev/better-auth@0.11.4for all three variants, zero rejected hunks.packages/@convex-dev/better-auth/bun/@convex-dev%2Fbetter-auth@0.11.4-pr323.patch(paths relative to package root)patch-package) patch atpackages/@convex-dev/better-auth/npm/@convex-dev+better-auth+0.11.4-pr323.patch(paths prefixed withnode_modules/@convex-dev/better-auth/)packages/@convex-dev/better-auth/pnpm/@convex-dev__better-auth@0.11.4-pr323.patch(paths relative to package root)README.md## Opentable linking the three patches and the upstream PRConsumers applying this patch must also bump
better-authin their app to^1.6.0so the new peer range resolves.