agentmanagement tests - cluster registration token - #5538
Merged
Conversation
This PR adds testing coverage for the cluster registration token controller. Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds envtest integration coverage for the ClusterRegistrationToken controller behavior in the agentmanagement suite, including TTL enforcement, generated RBAC, and the derived “cluster-registration-values” Secret.
Changes:
- Adds reusable
objectGoneasync assertion helper and anewClusterRegistrationTokentest constructor. - Introduces a comprehensive
clusterregistrationtoken_test.gosuite validating TTL rejection/expiry, generated ServiceAccount/Role/RoleBinding, values Secret contents, and pruning on deletion. - Includes envtest-specific logic to populate the ServiceAccount token Secret (since envtest won’t auto-populate SA token data).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| integrationtests/agentmanagement/helpers_test.go | Adds generic “object gone” assertion and a ClusterRegistrationToken factory helper used by new tests. |
| integrationtests/agentmanagement/clusterregistrationtoken_test.go | New integration test suite covering ClusterRegistrationToken lifecycle, RBAC, secret generation, TTL enforcement, and pruning behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
d3flex
reviewed
Aug 14, 2026
Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
p-se
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds testing coverage for the cluster registration token controller.