[v0.16] - Deploy charts that define CRDs and use lookup (#5689) - #5710
Merged
0xavi0 merged 1 commit intoSep 3, 2026
Merged
Conversation
* Deploy charts that define CRDs and use lookup Charts that both declare CRDs in `crds/` and instantiate custom resources of those kinds cannot be deployed when they also use the `lookup` function. `lookup` forces a server-side dry run, and a server-side dry run does not install `crds/`, so the rendered custom resources have no REST mapping yet and Helm fails with `no matches for kind`. The dry run is now skipped when the failure consists only of REST mapping failures for kinds the chart itself declares in `crds/` (including its dependencies'). The real install installs `crds/` before building the manifest, so it validates the chart without hitting the chicken-and-egg problem. Any other dry run failure is still reported as before, and template mode is unaffected. Refers to: rancher#5630 Signed-off-by: Xavi Garcia <xavi.garcia@suse.com> * Fix linter findings Signed-off-by: Xavi Garcia <xavi.garcia@suse.com> * return all leaf errors Signed-off-by: Xavi Garcia <xavi.garcia@suse.com> --------- Signed-off-by: Xavi Garcia <xavi.garcia@suse.com>
p-se
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports: #5689
Refers to: #5709