Skip to content

Bump Traefik image and chart#10499

Open
manuelbuil wants to merge 1 commit into
rancher:masterfrom
manuelbuil:updateTraefik371
Open

Bump Traefik image and chart#10499
manuelbuil wants to merge 1 commit into
rancher:masterfrom
manuelbuil:updateTraefik371

Conversation

@manuelbuil
Copy link
Copy Markdown
Contributor

@manuelbuil manuelbuil commented Jun 1, 2026

Proposed Changes

Bump Traefik chart and image.

The new Traefik v3.7.3 adds support for a lot of ingress-nginx annotations. Two of them were in our tests::

  • rewrite
  • vhost

This PR also modifies the internal test so we expect success when using those annotations now

Types of Changes

Version bump

Verification

Deploy RKE2 without setting any ingress-controller. Verify that:
1 - Traefik is deployed
2 - The version of traefik is v3.7.3
3 - kubeclt get crd | grep gateway.networking return 8 CRDs. If you output the CRD details, all 8 include the annotation "helm.sh/resource-policy: keep"

Testing

Linked Issues

#10498

User-Facing Change

Bump Traefik to v3.7.3

Further Comments

@manuelbuil manuelbuil requested a review from a team as a code owner June 1, 2026 12:23
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.82%. Comparing base (1e77db7) to head (4cf519c).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10499   +/-   ##
=======================================
  Coverage   19.82%   19.82%           
=======================================
  Files          50       50           
  Lines        4136     4136           
=======================================
  Hits          820      820           
  Misses       3265     3265           
  Partials       51       51           
Flag Coverage Δ
inttests 8.78% <ø> (ø)
unittests 14.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@brandond brandond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the chart is broken - did you validate that the patches in rke2-charts apply cleanly to the new 40.0 chart release from rancher/rke2-charts#1005?

    2026-06-01T15:59:17.244212737Z stderr F + helm install --set-string global.clusterCIDR=10.42.0.0/16 --set-string global.clusterCIDRv4=10.42.0.0/16 --set-string global.clusterDNS=10.43.0.10 --set-string global.clusterDomain=cluster.local --set global.prime.enabled=false --set-string global.rke2DataDir=/var/lib/rancher/rke2 --set-string global.serviceCIDR=10.43.0.0/16 --set-string global.systemDefaultIngressClass=traefik rke2-traefik /tmp/rke2-traefik.tgz
    2026-06-01T15:59:17.312855284Z stderr F Error: INSTALLATION FAILED: template: rke2-traefik/templates/migrationClass.yaml:1:14: executing "rke2-traefik/templates/migrationClass.yaml" at <.Values.providers.kubernetesIngressNginx.enabled>: nil pointer evaluating interface {}.enabled

@manuelbuil
Copy link
Copy Markdown
Contributor Author

Looks like the chart is broken - did you validate that the patches in rke2-charts apply cleanly to the new 40.0 chart release from rancher/rke2-charts#1005?

    2026-06-01T15:59:17.244212737Z stderr F + helm install --set-string global.clusterCIDR=10.42.0.0/16 --set-string global.clusterCIDRv4=10.42.0.0/16 --set-string global.clusterDNS=10.43.0.10 --set-string global.clusterDomain=cluster.local --set global.prime.enabled=false --set-string global.rke2DataDir=/var/lib/rancher/rke2 --set-string global.serviceCIDR=10.43.0.0/16 --set-string global.systemDefaultIngressClass=traefik rke2-traefik /tmp/rke2-traefik.tgz
    2026-06-01T15:59:17.312855284Z stderr F Error: INSTALLATION FAILED: template: rke2-traefik/templates/migrationClass.yaml:1:14: executing "rke2-traefik/templates/migrationClass.yaml" at <.Values.providers.kubernetesIngressNginx.enabled>: nil pointer evaluating interface {}.enabled

yes, there is a var that changed in the chart. Now Nginx is NGINX. I need to create a new chart with that change

@manuelbuil
Copy link
Copy Markdown
Contributor Author

This should fix it rancher/rke2-charts#1007

@manuelbuil
Copy link
Copy Markdown
Contributor Author

manuelbuil commented Jun 1, 2026

Now it installs correctly:

2026-06-01T20:39:22.3962482Z     2026-06-01T20:36:09.217935313Z stderr F + helm install --set-string global.clusterCIDR=10.42.0.0/16 --set-string global.clusterCIDRv4=10.42.0.0/16 --set-string global.clusterDNS=10.43.0.10 --set-string global.clusterDomain=cluster.local --set global.prime.enabled=false --set-string global.rke2DataDir=/var/lib/rancher/rke2 --set-string global.serviceCIDR=10.43.0.0/16 --set-string global.systemDefaultIngressClass=traefik rke2-traefik /tmp/rke2-traefik.tgz
2026-06-01T20:39:22.3965194Z     2026-06-01T20:36:09.61644021Z stdout F NAME: rke2-traefik
2026-06-01T20:39:22.3965753Z     2026-06-01T20:36:09.616473862Z stdout F LAST DEPLOYED: Mon Jun  1 20:36:09 2026
2026-06-01T20:39:22.3966294Z     2026-06-01T20:36:09.616478691Z stdout F NAMESPACE: kube-system
2026-06-01T20:39:22.3966755Z     2026-06-01T20:36:09.616482168Z stdout F STATUS: deployed
2026-06-01T20:39:22.3967162Z     2026-06-01T20:36:09.616485484Z stdout F REVISION: 1
2026-06-01T20:39:22.3967565Z     2026-06-01T20:36:09.61648859Z stdout F TEST SUITE: None
2026-06-01T20:39:22.3967962Z     2026-06-01T20:36:09.616491846Z stdout F NOTES:
2026-06-01T20:39:22.3969042Z     2026-06-01T20:36:09.617490113Z stdout F rke2-traefik with docker.io/rancher/hardened-traefik:v3.7.1-build20260601 has been deployed successfully on kube-system namespace!
2026-06-01T20:39:22.3969978Z     2026-06-01T20:36:09.617523515Z stdout F 
2026-06-01T20:39:22.3971138Z     2026-06-01T20:36:09.617529827Z stdout F ⚠️ WARNING: You are using a non-standard image tag (v3.7.1-build20260601). Non-standard versions can
2026-06-01T20:39:22.3972154Z     2026-06-01T20:36:09.617533494Z stdout F be unstable, may contain breaking changes, and are NOT recommended for production use.
2026-06-01T20:39:22.3973187Z     2026-06-01T20:36:09.61753673Z stdout F This version is not officially supported by this chart. Use at your own risk. ⚠️

but fails somewhere else... I'll continue tomorrow

@manuelbuil
Copy link
Copy Markdown
Contributor Author

As we are setting Traefik to be the default ingressClass, we need to change the name of the "default" ingressClass because it picks "rke2-traefik". Given that the new Traefik v3.7.2 is planned for tomorrow, I'll park this until the new image is out

Signed-off-by: Manuel Buil <mbuil@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants