Skip to content

Add xlsx-validator to travis build matrix - #520

Open
vindvaki wants to merge 2 commits into
randym:release-3.0.0from
vindvaki:release-3.0.0-with-xlsx-validator-ci
Open

Add xlsx-validator to travis build matrix#520
vindvaki wants to merge 2 commits into
randym:release-3.0.0from
vindvaki:release-3.0.0-with-xlsx-validator-ci

Conversation

@vindvaki

@vindvaki vindvaki commented Apr 1, 2017

Copy link
Copy Markdown

As promised in #501 (comment)

This adds a run of xlsx-validator on the files generated by examples/example.rb to the travis build matrix. You can see it in action on travis for my fork

These same steps can be used to run the validator locally as long as you have docker installed.

@vindvaki
vindvaki force-pushed the release-3.0.0-with-xlsx-validator-ci branch from 18263b4 to 1c802d0 Compare April 1, 2017 16:57
@vindvaki

vindvaki commented Apr 1, 2017

Copy link
Copy Markdown
Author

Oh and I guess your travis also uses the config from this PR for the build

@vindvaki

Copy link
Copy Markdown
Author

Turns out the validator does not catch any of the corruption errors of current master, which is a bummer. So the added value seems pretty marginal.

@vindvaki

Copy link
Copy Markdown
Author

Actually, it catches <a:round/>, paperHeight, and paperWidth, all of which caused trouble with Excel 2007. But it's also quite noisy:

  • here are some issues that don't cause a corrupt document prompt in excel
  • the main:sz error might be a false positive
  • if the examples were split into smaller files it would be easier to pinpoint issues with individual features

@vindvaki vindvaki mentioned this pull request May 9, 2017
@vindvaki

vindvaki commented May 9, 2017

Copy link
Copy Markdown
Author

@randym Could you please take a look? I've allowed failures for the validator build step, like you mentioned in #501.

@noniq

noniq commented Dec 20, 2019

Copy link
Copy Markdown
Collaborator

@vindvaki This looks like a promising feature. If you’re still interested in getting this merged, please reopen this PR in https://github.com/caxlsx/caxlsx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants