Harden pread and pwrite short I/O handling - #1110
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden the POSIX
pread/pwritepaths inCuFileDriveragainstEINTR, short transfers, EOF, and error propagation.What changed
pread/pwriteWhy
Several loops in
cufile_driver.cppassumed that eachpread/pwritereturned the full requested size.When that assumption breaks, the old code could:
This change keeps the public behavior close to POSIX short-read semantics while making the internal buffered/page-aligned logic robust against partial transfers and interruptions.
Validation
cufile_driver.cpptest_cufile.cppfor a short read near EOFgit diff --checkFindCUDAToolkitfails to locatenvcc