Forward-merge release/26.08 into main - #1124
Merged
Merged
Conversation
…bit indexing) (#1087) closes #1076 CuPy recently updated `cupyx.scipy.ndimage.label` to support 64-bit indexing when necessary to support large image sizes. See a more detailed description for the changes made in the upstream PR: cupy/cupy#9859 This MR makes the exact same change to the very similar kernels underlying `cucim.skimage.measure.label`. The reason we don't use CuPy kernels directly for cuCIM's `label` is that the CuPy API is for binary image labeling only (i.e. all foreground pixels are treated the same regardless of intensity). The version of `label` in the scikit-image API also supports a grayscale mode where neighboring pixels are only connected if the grayscale intensity is actually equal. Thus we have modified kernels that support that logic. The indexing concern and solution is the same as in the upstream PR, though. Authors: - Gregory Lee (https://github.com/grlee77) - https://github.com/jakirkham Approvers: - https://github.com/jakirkham URL: #1087
Contributor
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/26.08 that creates a PR to keep main up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.