Fix decimal interop

.github/CODEOWNERS

@@ -16,30 +16,36 @@
 # request a review from owners on PRs with changes to matching files.
 # We currently do not enforce these reviews as required so it's only a tool
 # for more granular notifications at the moment. For example component maintainers
-# can set a rule so that they are pinged on changes to the sections of the 
+# can set a rule so that they are pinged on changes to the sections of the
 # codebase that are relevant for their component.
 
 # Only users that have write access to the repo can be added as owners.
 # See the official docs for more details on syntax and precedence of rules: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners#example-of-a-codeowners-file
 
+# Velox-cuDF codeowners
+* @rapidsai/velox-cudf-codeowners
+
 # Build & CI
-CMake/ @assignUser @majetideepak
-*.cmake @assignUser @majetideepak
-**/CMakeLists.txt @assignUser @majetideepak
-scripts/ @assignUser @majetideepak
-.github/ @assignUser @majetideepak
+#CMake/ @assignUser @majetideepak
+#*.cmake @assignUser @majetideepak
+#**/CMakeLists.txt @assignUser @majetideepak
+#scripts/ @assignUser @majetideepak
+#.github/ @assignUser @majetideepak
+
+# Breeze
+#velox/experimental/breeze @dreveman
 
-# Breeze 
-velox/experimental/breeze @dreveman
+# cuDF
+velox/experimental/cudf @bdice @karthikeyann @devavret
 
 # Parquet
-velox/dwio/parquet/ @majetideepak
+#velox/dwio/parquet/ @majetideepak
 
 # Storage Adapters
-velox/connectors/hive/storage_adapters/ @majetideepak
+#velox/connectors/hive/storage_adapters/ @majetideepak
 
 # Connectors
-velox/connectors/ @majetideepak
+#velox/connectors/ @majetideepak
 
 # Caching
-velox/common/caching/ @majetideepak 
+#velox/common/caching/ @majetideepak

.github/copy-pr-bot.yaml

@@ -0,0 +1,4 @@
+# Configuration file for `copy-pr-bot` GitHub App
+# https://docs.gha-runners.nvidia.com/apps/copy-pr-bot/
+
+enabled: true

.github/workflows/benchmark.yml → .github/disabled-workflows/benchmark.yml

@@ -41,7 +41,7 @@ defaults:
 jobs:
   benchmark:
     if: github.repository == 'facebookincubator/velox'
-    runs-on: 8-core-ubuntu-22.04
+    runs-on: linux-amd64-cpu8
     env:
       CCACHE_DIR: "${{ github.workspace }}/ccache/"
       CCACHE_BASEDIR: "${{ github.workspace }}"
@@ -151,7 +151,7 @@ jobs:
         run: |
             make benchmarks-basic-run \
                 EXTRA_BENCHMARK_FLAGS="--binary_path ${BINARY_DIR}/contender/ --output_path ${CONTENDER_OUTPUT_PATH}"
-                
+
       - name: "Compare initial results"
         id: compare
         if: ${{ github.event_name == 'pull_request' }}
@@ -163,13 +163,13 @@ jobs:
                 --do_not_fail
 
       - name: "Rerun Benchmarks"
-        if: ${{ github.event_name == 'pull_request'}}    
+        if: ${{ github.event_name == 'pull_request'}}
         working-directory: 'velox'
         run: |
           for i in 1 2 3 4 5; do
             CURRENT_JSON_RERUN="${RESULTS_ROOT}/rerun_json_output_$((${i} - 1)).json"
             NEXT_JSON_RERUN="${RESULTS_ROOT}/rerun_json_output_${i}.json"
-  
+
             if [ ! -s "${CURRENT_JSON_RERUN}" ]; then
               echo "::notice::Rerun iteration ${i} found empty file. Finalizing."
               break
@@ -189,7 +189,7 @@ jobs:
                 --do_not_fail
           echo "::endgroup::"
           done
-          
+
 
           echo "::group::Compare final results"
           ./scripts/benchmark-runner.py compare \
@@ -207,7 +207,7 @@ jobs:
         with:
           path: "pr_number.txt"
           name: "pr_number"
-      
+
       - name: "Upload result artifact"
         uses: actions/upload-artifact@v4
         with:

.github/workflows/build-metrics.yml → .github/disabled-workflows/build-metrics.yml

@@ -42,7 +42,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        runner: ["16-core-ubuntu"]
+        runner: ["linux-amd64-cpu8"]
         type: ["debug", "release"]
         link-type: ["shared", "static"]
     defaults:

.github/workflows/experimental.yml → .github/disabled-workflows/experimental.yml

@@ -47,7 +47,7 @@ permissions:
 
 jobs:
   compile:
-    runs-on: 16-core-ubuntu
+    runs-on: linux-amd64-cpu8
     timeout-minutes: 120
     env:
       CCACHE_DIR: "${{ github.workspace }}/ccache/"
@@ -110,7 +110,7 @@ jobs:
           path: velox/_build/debug/velox/expression/fuzzer/spark_expression_fuzzer_test
 
   presto-java-aggregation-fuzzer-run:
-    runs-on: 16-core-ubuntu
+    runs-on: linux-amd64-cpu8
     container: ghcr.io/facebookincubator/velox-dev:presto-java
     timeout-minutes: 120
     env:

.github/workflows/scheduled.yml → .github/disabled-workflows/scheduled.yml

@@ -89,7 +89,7 @@ jobs:
     name: Build
     # prevent errors when forks ff their main branch
     if: ${{ github.repository == 'facebookincubator/velox' }}
-    runs-on: 32-core-ubuntu
+    runs-on: linux-amd64-cpu8
     container: ghcr.io/facebookincubator/velox-dev:centos9
     timeout-minutes: 120
     env:

.github/workflows/linux-build.yml

@@ -17,29 +17,8 @@ name: Linux Build using GCC
 on:
   push:
     branches:
-      - "main"
-    paths:
-      - "velox/**"
-      - "!velox/docs/**"
-      - "CMakeLists.txt"
-      - "CMake/**"
-      - "third_party/**"
-      - "scripts/setup-ubuntu.sh"
-      - "scripts/setup-helper-functions.sh"
-      - ".github/workflows/linux-build.yml"
-      - ".github/workflows/linux-build-base.yml"
-
-  pull_request:
-    paths:
-      - "velox/**"
-      - "!velox/docs/**"
-      - "CMakeLists.txt"
-      - "CMake/**"
-      - "third_party/**"
-      - "scripts/setup-ubuntu.sh"
-      - "scripts/setup-helper-functions.sh"
-      - ".github/workflows/linux-build.yml"
-      - ".github/workflows/linux-build-base.yml"
+      - "velox-cudf"
+      - "pull-request/[0-9]+"
 
 permissions:
   contents: read
@@ -49,6 +28,146 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  linux-gcc:
-    name: Build with GCC
-    uses: ./.github/workflows/linux-build-base.yml
+  adapters:
+    name: Linux release with adapters
+    runs-on: linux-amd64-cpu16
+    container: ghcr.io/facebookincubator/velox-dev:adapters
+    defaults:
+      run:
+        shell: bash
+    env:
+      CCACHE_DIR: "${{ github.workspace }}/.ccache"
+      VELOX_DEPENDENCY_SOURCE: SYSTEM
+      GTest_SOURCE: BUNDLED
+      simdjson_SOURCE: BUNDLED
+      xsimd_SOURCE: BUNDLED
+      Arrow_SOURCE: BUNDLED
+      Thrift_SOURCE: BUNDLED
+      cudf_SOURCE:  BUNDLED
+      CUDA_VERSION: "12.8"
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Fix git permissions
+        # Usually actions/checkout does this but as we run in a container
+        # it doesn't work
+        run: git config --global --add safe.directory ${GITHUB_WORKSPACE}
+
+      - name: Install Dependencies
+        run: |
+          # Allows to install arbitrary cuda-version whithout needing to update
+          # docker container before. It simplifies testing new/different versions
+          if ! yum list installed cuda-nvcc-$(echo ${CUDA_VERSION} | tr '.' '-') 1>/dev/null; then
+            source scripts/setup-centos9.sh
+            install_cuda ${CUDA_VERSION}
+          fi
+
+          # TODO: Install a newer cmake here until we update the images upstream
+          pip install cmake==3.30.4
+
+      # - uses: assignUser/stash/restore@v1
+      #   with:
+      #     token: '${{ secrets.ARTIFACT_CACHE_TOKEN }}'
+      #     path: '${{ env.CCACHE_DIR }}'
+      #     key: ccache-linux-adapters
+
+      - name: "Zero Ccache Statistics"
+        run: |
+          ccache -sz
+
+      - name: Make Release Build
+        env:
+          MAKEFLAGS: 'TREAT_WARNINGS_AS_ERRORS=0 NUM_THREADS=16 MAX_HIGH_MEM_JOBS=4'
+          CUDA_ARCHITECTURES: 70
+          CUDA_COMPILER: /usr/local/cuda-${CUDA_VERSION}/bin/nvcc
+          # Set compiler to GCC 12
+          CUDA_FLAGS: "-ccbin /opt/rh/gcc-toolset-12/root/usr/bin"
+        run: |
+          EXTRA_CMAKE_FLAGS=(
+            "-DVELOX_ENABLE_BENCHMARKS=ON"
+            "-DVELOX_ENABLE_ARROW=ON"
+            "-DVELOX_ENABLE_PARQUET=ON"
+            "-DVELOX_ENABLE_HDFS=ON"
+            "-DVELOX_ENABLE_S3=ON"
+            "-DVELOX_ENABLE_GCS=ON"
+            "-DVELOX_ENABLE_ABFS=ON"
+            "-DVELOX_ENABLE_REMOTE_FUNCTIONS=ON"
+            "-DVELOX_ENABLE_GPU=ON"
+            "-DVELOX_ENABLE_CUDF=ON"
+            "-DVELOX_MONO_LIBRARY=ON"
+          )
+          make release EXTRA_CMAKE_FLAGS="${EXTRA_CMAKE_FLAGS[*]}"
+
+      - name: Ccache after
+        run: ccache -s
+
+      - uses: assignUser/stash/save@v1
+        with:
+          path: '${{ env.CCACHE_DIR }}'
+          key: ccache-linux-adapters
+
+      - name: Run Tests
+        # Some of the adapters dependencies are in the 'adapters' conda env
+        shell: mamba run --no-capture-output -n adapters /usr/bin/bash -e {0}
+        env:
+          LIBHDFS3_CONF: "${{ github.workspace }}/scripts/hdfs-client.xml"
+        working-directory: _build/release
+        run: |
+          export CLASSPATH=`/usr/local/hadoop/bin/hdfs classpath --glob`
+          ctest -j 8 --label-exclude cuda_driver --output-on-failure --no-tests=error -E "velox_exec_test|velox_hdfs_file_test|velox_s3"
+
+# ubuntu-debug:
+#   runs-on: linux-amd64-cpu16
+#   name: "Ubuntu debug with resolve_dependency"
+#   env:
+#     CCACHE_DIR: "${{ github.workspace }}/.ccache"
+#   defaults:
+#     run:
+#       shell: bash
+#       working-directory: velox
+#   steps:
+
+#     - name: Get Ccache Stash
+#       uses: assignUser/stash/restore@v1
+#       with:
+#         token: '${{ secrets.ARTIFACT_CACHE_TOKEN }}'
+#         path: '${{ env.CCACHE_DIR }}'
+#         key: ccache-ubuntu-debug-default
+
+#     - name: Ensure Stash Dirs Exists
+#       working-directory: ${{ github.workspace }}
+#       run: |
+#         mkdir -p '${{ env.CCACHE_DIR }}'
+
+#     - uses: actions/checkout@v4
+#       with:
+#         path: velox
+
+#     - name: Install Dependencies
+#       run: |
+#         source scripts/setup-ubuntu.sh && install_apt_deps
+
+#     - name: Clear CCache Statistics
+#       run: |
+#         ccache -sz
+
+#     - name: Make Debug Build
+#       env:
+#         VELOX_DEPENDENCY_SOURCE: BUNDLED
+#         MAKEFLAGS: "TREAT_WARNINGS_AS_ERRORS=0 NUM_THREADS=16 MAX_HIGH_MEM_JOBS=4"
+#         EXTRA_CMAKE_FLAGS: "-DVELOX_ENABLE_ARROW=ON -DVELOX_ENABLE_PARQUET=ON"
+#       run: |
+#         make debug
+
+#     - name: CCache after
+#       run: |
+#         ccache -vs
+
+#     - uses: assignUser/stash/save@v1
+#       with:
+#         path: '${{ env.CCACHE_DIR }}'
+#         key: ccache-ubuntu-debug-default
+
+#     - name: Run Tests
+#       run: |
+#         cd _build/debug && ctest -j 8 --output-on-failure --no-tests=error -E "velox_exec_test"

.github/workflows/preliminary_checks.yml

@@ -14,12 +14,9 @@
 name: Run Checks
 
 on:
-  pull_request:
-    types:
-      - opened
-      - reopened
-      - edited
-      - synchronize
+  push:
+    branches:
+      - "pull-request/[0-9]+"
 
 permissions:
   contents: read
@@ -37,10 +34,10 @@ jobs:
       fail-fast: false
       matrix:
         config:
-          - { name: "License Header",
-              command: "header-fix",
-              message: "Found missing License Header(s)",
-            }
+#         - { name: "License Header",
+#             command: "header-fix",
+#             message: "Found missing License Header(s)",
+#           }
           - { name: "Code Format",
               command: "format-fix",
               message: "Found format issues"
@@ -76,22 +73,22 @@ jobs:
             exit 1
           fi
 
-  title-check:
-    name: PR Title Format
-    runs-on: ubuntu-latest
-    steps:
-      - shell: python
-        env:
-          title: "${{ github.event.pull_request.title }}"
-        run: |
-          import re
-          import os
-          title = os.environ["title"]
-          title_re = r"^(feat|fix|build|test|docs|refactor|misc)(\(.+\))?!?: ([A-Z].+)[^.]$"
-          match = re.search(title_re, title)
+# title-check:
+#   name: PR Title Format
+#   runs-on: ubuntu-latest
+#   steps:
+#     - shell: python
+#       env:
+#         title: "${{ github.event.pull_request.title }}"
+#       run: |
+#         import re
+#         import os
+#         title = os.environ["title"]
+#         title_re = r"^(feat|fix|build|test|docs|refactor|misc)(\(.+\))?!?: ([A-Z].+)[^.]$"
+#         match = re.search(title_re, title)
 
-          if match is None:
-            print("::error::Please follow conventional commit guidelines in commit titles as described in CONTRIBUTING.md: https://github.com/facebookincubator/velox/blob/main/CONTRIBUTING.md#commit-messages")
-            exit(1)
-          else:
-            exit(0)
+#         if match is None:
+#           print("::error::Please follow conventional commit guidelines in commit titles as described in CONTRIBUTING.md: https://github.com/facebookincubator/velox/blob/main/CONTRIBUTING.md#commit-messages")
+#           exit(1)
+#         else:
+#           exit(0)