Add boost padding - #114
Merged
Merged
Conversation
renan028
marked this pull request as ready for review
August 1, 2025 07:38
vsamy
reviewed
Aug 5, 2025
vsamy
left a comment
There was a problem hiding this comment.
Last time I did this it was working fine
Do we need a new dependency just for polygon inflation?
Author
I have checked some solutions like the one you proposed, but they all have some corner cases missing. The library is very known though, with ~500 stars. And it looks more complete than boost. Maybe we can replace boost geometry in Nav by this one, if boost cannot handle the case. |
Author
Nisarg236
reviewed
Aug 9, 2025
Nisarg236
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Use boost library to compute correct polyline offset.
When we use footprint_padding of
0.06(6cm), for instance, the old behavior adds around 2cm only, and the polygon is distorted:After changing to boost:
