Merged
Conversation
Resolve TypeScript to the latest 5.x patch release while keeping the existing package range. This avoids the TypeScript 6 peer dependency mismatch in the current Astro tooling.
Deploying ratatui with
|
| Latest commit: |
19403fe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ffd809f4.ratatui.pages.dev |
| Branch Preview URL: | https://joshka-refresh-typescript-lo.ratatui.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm-lock.yamlpackage.jsonrange on TypeScript 5 so Astro tooling remains inside its declared peer dependency supportWhy not TypeScript 6 yet?
TypeScript 6 is the npm latest, but it is a real migration release rather than a routine patch update. The TypeScript 6 notes call out changed compiler defaults, root directory behavior, stricter side-effect import handling, deprecated options, and other migration concerns.
Astro support is also still catching up:
@astrojs/check@0.9.8still requiringtypescript@^5.0.0.tsconfckis being discontinued, the new recommended way is to useget-tsconfig. withastro/astro#16385 tracks Astro still depending ontsconfck, which also declarestypescript@^5.0.0and is being discontinued.tsconfckwithget-tsconfig; it is not merged yet.Keeping this PR to TypeScript 5.9.3 gets the latest supported 5.x patch without opting into peer dependency overrides or upstream compatibility assumptions.
Validation
mise exec -- corepack pnpm install --frozen-lockfilemise exec -- corepack pnpm test -- --runmise exec -- corepack pnpm format:checkmise run build