feat: update apsara to 1.0.0-rc.6#1594
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughBumps the ChangesApsara v1 Dependency & Component Migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
web/sdk/react/views-new/billing/components/upcoming-billing-cycle.tsx (1)
174-202:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winFix invalid HTML structure: nested
<p>elements created by removingas="span".The code nests
Textcomponents without theasprop at lines 174, 191, 196, and 202. Since Apsara's Text component defaults to rendering as a<p>element, these changes produce invalid HTML:<p><p>Label</p></p>.To fix, either:
- Add
as="span"back to the innerTextelements (labels), or- Add
as="div"to the outerTextelements.The pattern appears in all four label/value sections (Plan, Next billing, Users, Amount).
🧹 Nitpick comments (1)
web/sdk/react/utils/transform-query.ts (1)
25-25: ⚡ Quick winConsider documenting the
unknownparameter type.The widening from a specific union to
unknownreduces compile-time type safety. Since the function now accepts any value, it would be helpful to document what types are expected in practice and how non-primitive types are handled (converted viaString()).📝 Suggested JSDoc addition
/** * Converts a filter value to the appropriate RQLFilter value format + * `@param` value - Filter value of any type; primitives (boolean, number, string) are + * preserved with type information, while objects/arrays are stringified */ function convertFilterValue(value: unknown): RQLFilter["value"] {
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 43db9027-729f-43c1-8271-d759544e9a0d
⛔ Files ignored due to path filters (1)
web/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (27)
web/sdk/package.jsonweb/sdk/react/utils/transform-query.tsweb/sdk/react/views-new/auth/magic-link-verify/magic-link-verify-view.tsxweb/sdk/react/views-new/auth/magic-link/magic-link-view.tsxweb/sdk/react/views-new/auth/subscribe/subscribe-view.tsxweb/sdk/react/views-new/billing/components/confirm-cycle-switch-dialog.tsxweb/sdk/react/views-new/billing/components/upcoming-billing-cycle.tsxweb/sdk/react/views-new/create-organization/create-organization-view.tsxweb/sdk/react/views-new/general/components/delete-organization-dialog.tsxweb/sdk/react/views-new/general/general-view.tsxweb/sdk/react/views-new/members/components/invite-member-dialog.tsxweb/sdk/react/views-new/members/components/member-columns.tsxweb/sdk/react/views-new/pat/components/pat-created-dialog.tsxweb/sdk/react/views-new/pat/components/pat-form-dialog.tsxweb/sdk/react/views-new/pat/components/pat-project-chips.tsxweb/sdk/react/views-new/plans/components/confirm-plan-change-dialog.tsxweb/sdk/react/views-new/profile/profile-view.tsxweb/sdk/react/views-new/projects/components/add-project-dialog.tsxweb/sdk/react/views-new/projects/components/edit-project-dialog.tsxweb/sdk/react/views-new/security/components/add-domain-dialog.tsxweb/sdk/react/views-new/security/components/delete-domain-dialog.tsxweb/sdk/react/views-new/security/components/verify-domain-dialog.tsxweb/sdk/react/views-new/service-accounts/components/add-service-account-dialog.tsxweb/sdk/react/views-new/service-accounts/components/add-token-form.tsxweb/sdk/react/views-new/teams/components/add-team-dialog.tsxweb/sdk/react/views-new/teams/components/edit-team-dialog.tsxweb/sdk/react/views-new/tokens/components/add-tokens-dialog.tsx
Coverage Report for CI Build 25716229773Coverage remained the same at 41.985%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
paanSinghCoder
approved these changes
May 11, 2026
rohanchkrabrty
changed the title
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@raystack/apsara-v1alias to@raystack/apsara@1.0.0-rc.6in the SDK package.InputFieldusages acrossviews-new(auth, billing, profile, projects, security, members, teams, tokens, PATs, create-organization, general) to the newField+Inputcomposition exposed by Apsara v1.pat-form-dialog'sSelect.Valuerender so visible/remaining chip computation lives outside the render prop, matching the updatedSelectAPI.convertFilterValueintransform-query.tsto acceptunknownand stringify non-primitive values safely.AlertDialog.showCloseButton→ false,Tabs.size→ medium,Select.align→ bottom-start, Toast offset 24px) that match existing SDK usage patterns; additive props (onValueChangeon Input/Search/TextArea,renderon Link) are non-breaking.