Add PicoRuby 3.4.2 with new r2p2 executable#2614
Open
hasumikin wants to merge 1 commit intorbenv:masterfrom
Open
Add PicoRuby 3.4.2 with new r2p2 executable#2614hasumikin wants to merge 1 commit intorbenv:masterfrom
hasumikin wants to merge 1 commit intorbenv:masterfrom
Conversation
mislav
requested changes
Apr 9, 2026
Member
mislav
left a comment
mislav
left a comment
There was a problem hiding this comment.
Hi, thanks for the contribution and sorry for the late review!
| ln -fs picoirb "$PREFIX_PATH/bin/irb" | ||
| } | ||
|
|
||
| build_package_picoruby_r2p2() { |
Member
There was a problem hiding this comment.
I appreciate the effort, but I am not sold on the separate build function for picoruby releases going forward. If the only change is that picoruby-3.4 does not ship with picoirb going forward, I would edit the existing build_package_picoruby function to make the following step be conditional based on the existence of picoirb:
ln -fs picoirb "$PREFIX_PATH/bin/irb"Does that make sense or am I missing some potential drawbacks?
Contributor
Author
There was a problem hiding this comment.
@mislav
You are right. I fixed my implementation. Check it again when you have time
This commit adds PicoRuby 3.4.2 and introduces a new artifacts: r2p2. Version numbering context: PicoRuby's version numbers are aligned with mruby's VM code specification compatibility. Version 3.4 indicates compatibility with mruby 3.4 VM code format, or RITE0300. Version 3.4.2 indicates minor bug fix in PicoRuby. Build artifact changes: Starting from version 3.4.2, PicoRuby has replaced the irb executable with r2p2 executable(POSIX version of PicoRuby shell system including IRB). The new build produces three executables: - picoruby: main Ruby interpreter - picorbc: Ruby bytecode compiler - r2p2: interactive REPL (replaces picoirb) Implementation: - Added conditional symlink logic in `build_package_picoruby()`: symlinks picoirb as irb if present - If there's no picoirb in artifacts, symlink for irb is not created - Added picoruby-3.4.2 definition file
hasumikin
force-pushed
the
picoruby-3.4.2
branch
from
f7a161a to
d27dd19
Compare
hasumikin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds PicoRuby 3.4.2 and introduces a
new build function to accommodate changes in the build artifacts.new artifacts: r2p2Version numbering context:
PicoRuby's version numbers are aligned with mruby's VM code specification compatibility. Version 3.4 indicates compatibility with mruby 3.4 VM code format, or RITE0300. Version 3.4.2 indicates minor bug fix in PicoRuby.
Build artifact changes:
Starting from version 3.4.2, PicoRuby has replaced the irb executable with r2p2 (POSIX version of PicoRuby shell system including IRB). The new build produces three executables:
Implementation:
Added build_package_picoruby_r2p2() function for version 3.4.2+Existing build_package_picoruby() remains for version 3.0.0The new function creates only the 'ruby' symlink, omitting 'irb'build_package_picoruby(): symlinks picoirb as irb if presentThe split in build functions allows proper support for both the legacy 3.0.0 release with irb and newer releases with r2p2.