Issue115#142
Open
TaurahSP wants to merge 3 commits into
Open
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
…n parameter as drop database command cannot be used inside a transaction
rdagumampan
reviewed
Dec 20, 2020
| "Yuniql.CLI": { | ||
| "commandName": "Project", | ||
| "commandLineArgs": "platforms", | ||
| "commandLineArgs": "drop --force", |
Owner
There was a problem hiding this comment.
I think its better we keep the old values. Its dangeours to default this to drop :)
rdagumampan
reviewed
Dec 20, 2020
| }); | ||
| } | ||
|
|
||
| public virtual void RunNonVersionDropScripts(IDbConnection connection, |
Owner
There was a problem hiding this comment.
Why do you create a new RunNonVersionDropScripts? Is RunNonVersionScripts sufficient for this?
rdagumampan
requested changes
Dec 20, 2020
rdagumampan
left a comment
rdagumampan
left a comment
Owner
There was a problem hiding this comment.
Hi @TaurahSP , finally had time to review your changes. Thanks again for this feature. Few comments.
- Why do you create a new RunNonVersionDropScripts? Is RunNonVersionScripts sufficient for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new method RunNonVersionDropScripts which do not has the transaction parameter as drop database command cannot be used inside a transaction . https://docs.microsoft.com/en-us/previous-versions/sql/sql-server-2008-r2/ms191544(v=sql.105)?redirectedfrom=MSDN