Skip to content

Fix Range crash when press arrow keys (left, right, up, down)#531

Merged
zombieJ merged 3 commits intoreact-component:masterfrom
ztplz:master
Feb 23, 2019
Merged

Fix Range crash when press arrow keys (left, right, up, down)#531
zombieJ merged 3 commits intoreact-component:masterfrom
ztplz:master

Conversation

@ztplz
Copy link
Copy Markdown
Contributor

@ztplz ztplz commented Feb 21, 2019

@ztplz
Copy link
Copy Markdown
Contributor Author

ztplz commented Feb 21, 2019

@afc163 @zombieJ
原来的逻辑其实是不支持 mouseup后就认为这次移动结束了 就把handle设置为null了 但是这时用键盘移动的时候 handle是null的 然后就carsh了 但是点两次可以 要触发一次blur事件 把mouseup的监听事件移除

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 21, 2019

Codecov Report

Merging #531 into master will increase coverage by 0.03%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   83.51%   83.54%   +0.03%     
==========================================
  Files          10       10              
  Lines         467      468       +1     
  Branches      122      124       +2     
==========================================
+ Hits          390      391       +1     
  Misses         77       77
Impacted Files Coverage Δ
src/Range.jsx 60.89% <75%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a21ba5...591bd37. Read the comment docs.

@zombieJ
Copy link
Copy Markdown
Member

zombieJ commented Feb 21, 2019

加个测试吧~

@ztplz
Copy link
Copy Markdown
Contributor Author

ztplz commented Feb 21, 2019

改的好像不止这一点 发现原来的还有一个bug

@afc163
Copy link
Copy Markdown
Member

afc163 commented Feb 21, 2019

#510 看看是不是同一个问题

@ztplz
Copy link
Copy Markdown
Contributor Author

ztplz commented Feb 21, 2019

他的这个修复还是会crash
image这里也要加的 跟我的意思差不多

@ztplz
Copy link
Copy Markdown
Contributor Author

ztplz commented Feb 22, 2019

untitled7

@ztplz
Copy link
Copy Markdown
Contributor Author

ztplz commented Feb 22, 2019

#505

@afc163 afc163 requested a review from zombieJ February 22, 2019 07:30
@zombieJ
Copy link
Copy Markdown
Member

zombieJ commented Feb 23, 2019

加个测试…………

@zombieJ zombieJ merged commit 9007264 into react-component:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants