Implement support for CSS light-dark() in css.defineVars#497
Open
efoken wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in the StyleX docs, modern browsers should use the
light-dark()CSS function instead of theme-based overrides. This simplifies the code and removes the need to explicitly define dark mode themes.This PR adds support for
light-dark()incss.defineVars:For React Native, this is functionally equivalent to defining separate values and resolving them via the
@media (prefers-color-scheme: dark)Media Query.In modern browsers,
light-dark()also allows the color scheme to be controlled via thecolor-schemeCSS property, instead of relying on custom theme logic or duplicated Media Query-based definitions.This aligns the implementation with the current StyleX recommendation and modern CSS color-scheme handling.