DataStore: deprecate toKotlinObject - #2964
Open
Luna712 wants to merge 2 commits into
Open
Conversation
1. It can sometimes cause type erasure 2. It is less clear what it is doing 3. It is easy to replace 4. It is very rarely used, almost all app usage has already been replaced, and I haven't found any extensions actually using it but still following normal deprecation cycle as some still might be using it.
Contributor
Author
| imports = ["com.lagradost.cloudstream3.utils.AppUtils.parseJson"], | ||
| ), | ||
| ) | ||
| inline fun <reified T : Any> String.toKotlinObject(): T { |
Collaborator
There was a problem hiding this comment.
Can't we keep this extension function? It should not cause type erasure and it could be renamed for clarity.
Having extension functions helps with chained calls such as:
text.lowercase()
.substringAfter("[")
.substringBefore("]")
.trim()
.parseJson<…>()And it would be a good complement to toJson()
Contributor
Author
There was a problem hiding this comment.
We should still deprecate this and add the new version to AppUtils then I think. I am a little busy IRL now to work on things though but should be back more next week again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.