Skip to content

RI-8268 Translate all backend error codes (round 3)#6127

Merged
valkirilov merged 3 commits into
mainfrom
fe/RI-8268/translate-error-codes
Jul 8, 2026
Merged

RI-8268 Translate all backend error codes (round 3)#6127
valkirilov merged 3 commits into
mainfrom
fe/RI-8268/translate-error-codes

Conversation

@valkirilov

@valkirilov valkirilov commented Jun 29, 2026

Copy link
Copy Markdown
Member

What

Round 3 of frontend notification translation, stacked on the baseline (#6126). Fills in i18n coverage for all remaining backend error codes from #6125 — going from 15 to ~80 translated codes.

Data-only. Round 1 wired a fully dynamic lookup (getTranslatedApiError / getTranslatedApiTitle resolve notification.error.code.<n>.title / .message at runtime, with English fallback; removeUnusedKeys: false). So this PR adds keys to en.json + bg.json only — no .tsx changes — and coded errors now render a
localized title + body instead of the backend English.

Per-domain commits:

  • connection (10900–10908)
  • cloud API/OAuth/CAPI gaps (11007–11023)
  • cloud jobs (11100–11116)
  • database (11200)
  • AI (11300–11304 / 11351–11362)
  • RDI (11402–11411)
  • import (11700–11710)
  • encryption (11800–11807)
  • misc (11900–11901)
  • generic/validation titles (12100, 12400–12500)

Conventions kept from rounds 1–2:

  • Title from a concise localized heading; message from the backend text.
  • Codes whose backend message carries runtime detail get a .title only, so the backend message (with its specifics) still shows: 10905/10907 (connection), 11407/11408/11409 (RDI pipeline, like 11401), and the generic 12_xxx family.
  • en/bg key parity (301/301), i18n:extract canonical order (idempotent).

Testing

  • yarn type-check (additive keys, baseline clean), yarn test (error/notification specs green), yarn i18n:extract (no churn, parity holds).
  • Manual: with yarn dev:ui, dispatch a raw coded error from the console and confirm localized title+body, plus ?lang=bg:
    store.dispatch(addErrorNotification(getAxiosError({ response: { data: { errorCode: 11700 } } })))

Part of RI-8268

Related community requests: #605, #1317, #1883, #2040, #2137, #2181, #2213, #2417, #2550, #2590, #2695, #2715, #2716, #2727, #2828, #2912, #2943, #2945, #3081, #3141, #3142, #3319, #3411, #3601, #3625, #3628, #3663, #3671, #3812, #3815, #4150, #4182, #4408, #4664, #4672, #4744, #5052, #5967


Note

Low Risk
Mostly additive locale JSON plus a small notification display tweak; no auth or API behavior changes.

Overview
Adds localized title and message strings for the remaining backend api.error.code.* entries in en.json and bg.json, so coded API errors can show translated copy via the existing dynamic lookup (with English fallback). Coverage spans connection, cloud/OAuth, jobs, AI, RDI, SSH/tunnel, import, encryption, config, and generic HTTP-style codes; some codes are title-only where the backend still supplies runtime detail.

DefaultErrorContent now renders through a styled ErrorText with white-space: pre-line, so translated bodies that include \n (e.g. {{detail}} lines) break onto separate lines in notifications.

Also adds settings.language.* keys alongside the existing general language settings strings.

Reviewed by Cursor Bugbot for commit ab1cafa. Bugbot is set up for automated code reviews on this repo. Configure here.

@valkirilov valkirilov changed the title RI-8268 [i18n] Frontend: translate all backend error codes (round 3) RI-8268 Translate all backend error codes (round 3) Jun 29, 2026
@jit-ci

jit-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

@valkirilov valkirilov marked this pull request as ready for review June 29, 2026 13:35
@valkirilov valkirilov requested a review from a team as a code owner June 29, 2026 13:35
@valkirilov valkirilov force-pushed the fe/RI-8268/translate-error-codes branch from ec81b1c to 618d0da Compare June 29, 2026 13:36

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ec81b1c2e9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread redisinsight/ui/src/i18n/locales/en.json Outdated
Comment thread redisinsight/ui/src/i18n/locales/en.json Outdated
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Code Coverage - Integration Tests

Status Category Percentage Covered / Total
🟡 Statements 79.12% 18070/22838
🟡 Branches 61.88% 8375/13534
🟡 Functions 66.86% 2448/3661
🟡 Lines 78.73% 17008/21602

Comment thread redisinsight/ui/src/i18n/locales/bg.json Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ba130f4cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread redisinsight/ui/src/i18n/locales/en.json Outdated
@valkirilov valkirilov force-pushed the fe/RI-8268/translate-success-infinite branch from e63fa65 to b5ffaae Compare June 30, 2026 09:56
@valkirilov valkirilov force-pushed the fe/RI-8268/translate-error-codes branch from 8ba130f to 7811f9f Compare June 30, 2026 10:31
Comment thread redisinsight/ui/src/i18n/locales/en.json Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7811f9f892

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread redisinsight/ui/src/i18n/locales/en.json Outdated
Comment thread redisinsight/ui/src/i18n/locales/en.json Outdated
@valkirilov valkirilov force-pushed the fe/RI-8268/translate-error-codes branch from 7811f9f to 260a0b1 Compare June 30, 2026 10:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 260a0b11d0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread redisinsight/ui/src/i18n/locales/en.json Outdated
Comment thread redisinsight/ui/src/i18n/locales/en.json Outdated
Comment thread redisinsight/ui/src/i18n/locales/bg.json

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 904c12ac2e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread redisinsight/ui/src/i18n/locales/en.json
@valkirilov valkirilov self-assigned this Jul 1, 2026
@valkirilov valkirilov force-pushed the fe/RI-8268/translate-success-infinite branch from 403254f to 12f1111 Compare July 2, 2026 09:55
@valkirilov valkirilov force-pushed the fe/RI-8268/translate-error-codes branch from 7dc70db to 5c6f079 Compare July 2, 2026 09:58

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5c6f079a24

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread redisinsight/ui/src/i18n/locales/en.json
Comment thread redisinsight/ui/src/i18n/locales/en.json
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Code Coverage - Frontend unit tests

St.
Category Percentage Covered / Total
🟢 Statements 83.74% 26964/32201
🟡 Branches 69.46% 11470/16513
🟡 Functions 79.07% 7211/9120
🟢 Lines 84.21% 26263/31187

Test suite run success

7662 tests passing in 853 suites.

Report generated by 🧪jest coverage report action from ab1cafa

@valkirilov valkirilov force-pushed the fe/RI-8268/translate-success-infinite branch from 12f1111 to 1a6659f Compare July 2, 2026 11:43
@valkirilov valkirilov force-pushed the fe/RI-8268/translate-error-codes branch from 5c6f079 to 8dc98e3 Compare July 2, 2026 11:43
@valkirilov valkirilov force-pushed the fe/RI-8268/translate-success-infinite branch from 1a6659f to 042c0a2 Compare July 2, 2026 12:03
@valkirilov valkirilov force-pushed the fe/RI-8268/translate-error-codes branch from 8dc98e3 to b0a0d6b Compare July 2, 2026 12:10
Base automatically changed from fe/RI-8268/translate-success-infinite to main July 2, 2026 13:55
@valkirilov valkirilov force-pushed the fe/RI-8268/translate-error-codes branch 2 times, most recently from ea9045f to f3efe5b Compare July 6, 2026 07:26
valkirilov and others added 2 commits July 8, 2026 10:51
Add api.error.code.<n>.{title,message,...} for the remaining backend error codes
(connection, cloud jobs, AI, RDI, import, encryption, misc, generic). Rebuilt on
the api.error.code.* namespace; the per-code error text now lives under api.* while
FE toast chrome stays under notification.*. en/bg parity, 301 keys.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Title-only entries so the heading localizes while the backend message (which
carries the sanitized runtime detail) still shows. Closes the SSH range gap.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
* feat(ui): localize interpolated backend error messages (RI-8268)
* fix(ui): render newlines in the default error toast body (RI-8268)

Refs: RI-8268
@valkirilov valkirilov force-pushed the fe/RI-8268/translate-error-codes branch from f3efe5b to ab1cafa Compare July 8, 2026 08:06

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ab1cafa. Configure here.

Comment thread redisinsight/ui/src/i18n/locales/en.json

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ab1cafabbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread redisinsight/ui/src/i18n/locales/en.json
@valkirilov valkirilov merged commit 811c05d into main Jul 8, 2026
21 checks passed
@valkirilov valkirilov deleted the fe/RI-8268/translate-error-codes branch July 8, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants