RI-8272 i18n: migrate settings pages#6154
Conversation
Route Theme, Language, Notifications title, and Date/Time formatter user-facing strings through t() under settings.general.*, including the theme and timezone dropdown option labels. Retire the unused settings.language.* orphan keys. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Route Workbench editor-cleanup and pipeline strings through t() under settings.workbench.*; the pipeline summary uses <Trans> for its inline docs link. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Route Redis Cloud API-keys settings and the keys table through t() under settings.cloud.*; link/interpolation strings use <Trans>. Derive the clear-keys URL from the shared EXTERNAL_LINKS constant instead of a hardcoded literal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Route the keys-to-scan advanced setting strings through t() under settings.advanced.*. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Route the Redis Insight version label through t() with version interpolation (settings.appVersion). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Prettier fix for the general settings migration. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Route the Privacy section intro and Usage Data title through t() under settings.privacy.*. Consent toggle labels/descriptions remain backend-supplied and out of scope. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d887cfa35f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Code Coverage - Frontend unit tests
Test suite run success7593 tests passing in 847 suites. Report generated by 🧪jest coverage report action from d03e2b8 |
|
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 70.3%, saving 203.4 KB.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7199cc0. Configure here.
The API-keys delete confirmation interpolated the (user-named) key into a <Trans> markup string with escapeValue off, so a name containing </> could render as markup. Escape it via a shared escapeTrans helper (extracted from success-messages.tsx to uiSrc/i18n, now reused in both). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
7199cc0 to
d03e2b8
Compare

What
Migrate the Settings pages' user-facing strings to i18next (
t()/<Trans>). New keys are namespaced by settings section undersettings.*(general,privacy,workbench,cloud,advanced) plussettings.appVersion, with English + Bulgarian added toen.json/bg.json. Per-section coverage is shown in the screenshots below.Screenshots (EN | BG)
Testing
?lang=bg); verify each section renders translated.Closes RI-8272
Related community requests: #605, #1317, #1883, #2040, #2137, #2181, #2213, #2417, #2550, #2590, #2695, #2715, #2716, #2727, #2828, #2912, #2943, #2945, #3081, #3141, #3142, #3319, #3411, #3601, #3625, #3628, #3663, #3671, #3812, #3815, #4150, #4182, #4408, #4664, #4672, #4744, #5052, #5967
🤖 Generated with Claude Code
Note
Low Risk
UI-only string and translation wiring; settings behavior and persistence are unchanged aside from displayed text and link markup.
Overview
Migrates Settings user-facing copy to i18next (
t()/<Trans>) across General (language, theme, date/time, notifications header), Privacy, Workbench, Redis Cloud, Advanced, and the app version footer. New strings live undersettings.*inen.jsonandbg.json, with oldersettings.language.*keys folded intosettings.general.language.*.Cloud and Workbench sections use
<Trans>for inline links (Redis Cloud sign-in, pipelining docs); Redis Cloud delete flows useescapeTranson dynamic API key names.escapeTransis moved fromsuccess-messages.tsxintouiSrc/i18n/escapeTrans.tsand re-exported from the i18n barrel.Consent toggle labels/descriptions are unchanged—they still come from the backend agreements spec (called out as out of scope).
Reviewed by Cursor Bugbot for commit d03e2b8. Bugbot is set up for automated code reviews on this repo. Configure here.