Make host/port editable for non-managed databases #6155
Open
pawelangelow wants to merge 5 commits into
Open
Conversation
Contributor
Code Coverage - Backend unit tests
Test suite run success3654 tests passing in 319 suites. Report generated by 🧪jest coverage report action from 90f7bc3 |
Contributor
Code Coverage - Frontend unit tests
Test suite run success7600 tests passing in 847 suites. Report generated by 🧪jest coverage report action from 90f7bc3 |
Contributor
Code Coverage - Integration Tests
|
valkirilov
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Makes a database's host and port editable from the edit connection
form for non-managed databases, while keeping the endpoint locked for
cloud-managed databases (Redis Cloud and Azure).
Relates to #6148 and #5752
Note
Medium Risk
Changes database update validation and connection endpoint editing; misclassification of managed vs non-managed could block legitimate edits or allow stale cloud metadata.
Overview
Non-managed databases can now change host and port in the edit connection form; Redis Cloud and Azure managed instances keep a read-only endpoint in the UI and on the API.
The API adds a guard on
PATCH /databases/:idthat rejects host/port changes whencloudDetails.cloudIdorproviderDetailsis present, usingisEndpointChangedso unchanged values in the payload are not treated as edits. When a non-managed DB still uses the defaulthost:portalias, the display name is synced to the new endpoint unless the user set a custom name or sends an explicitname.The UI introduces
isManagedDatabase(aligned withDatabaseService.isManagedDatabase), wiresisManagedthrough the manual connection flow, shows editable host/port inEditConnectiononly for non-managed edits, and adjustsDbInfoso read-only endpoint summary appears for managed/cloud cases. Coverage includes unit, API integration, and Playwright e2e for edit host behavior.Reviewed by Cursor Bugbot for commit 90f7bc3. Bugbot is set up for automated code reviews on this repo. Configure here.