-
Notifications
You must be signed in to change notification settings - Fork 763
RFC ts-ct-migration: metastore and L1 reader [PR 1] #30800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sjust-redpanda
wants to merge
9
commits into
redpanda-data:dev
Choose a base branch
from
sjust-redpanda:sjust/ts-ct-migration-pr1
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5,361
−920
Draft
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
15928dd
cloud_storage: split offset_index into its own library
sjust-redpanda 3f11ea1
cloud_topics/l1: carry tiered-storage segment metadata in L1
sjust-redpanda aee815e
cloud_topics/l1: add a per-partition migrating flag to the metastore
sjust-redpanda 67e51da
cloud_topics/l1: register imported segments through add_objects
sjust-redpanda 9d2232c
cloud_topics/l1: read L1 objects through an open_object/object_handle…
sjust-redpanda 1cc5c96
cloud_topics/l1: add a chunked data source
sjust-redpanda 361ce4c
cloud_topics/l1: add the imported tiered-storage reader and index types
sjust-redpanda d206f59
cloud_topics/l1: serve imported tiered-storage segments
sjust-redpanda 5b8a9f6
cloud_topics/l1: delete an imported segment's tiered-storage objects
sjust-redpanda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code is removed, not moved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean, offset_index.h/cc seem to have what was removed from remote_segment_index.h/cc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me the diff appears as if it only removes the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe middleman renders the diff incorrectly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, I see 6e0f837 adding offset_index.h/cc, and I seem them still present in the final unified diff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, gitk does an interesting thing. It actually shows offset_index.h/cc as a copy of remote_segment_index.h/cc with lines removed. That might be what you're seeing.