-
Notifications
You must be signed in to change notification settings - Fork 763
rptest: add skip_in_cdt opt-out for CDT runs #30975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from all commits
047867c
d85a273
d12b4b2
f308052
3d3b021
489c8e5
1cf86c7
65c6139
51f8c9f
860377b
76f002c
0347371
367d670
3e76378
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -68,7 +68,11 @@ | |
| wait_until_result, | ||
| ) | ||
| from rptest.utils.log_utils import wait_until_nag_is_set | ||
| from rptest.utils.mode_checks import skip_debug_mode, skip_fips_mode | ||
| from rptest.utils.mode_checks import ( | ||
| skip_debug_mode, | ||
| skip_file_in_cdt, | ||
| skip_fips_mode, | ||
| ) | ||
|
|
||
| Headers: TypeAlias = dict[str, str] | None | ||
|
|
||
|
|
@@ -11947,3 +11951,13 @@ def test_transport_compatibility(self): | |
|
|
||
| self._flip_transport(use_rpc=False) | ||
| self._verify_phase(after_rpc2, "kafka2", "Kafka2Rec", n) | ||
|
|
||
|
|
||
| # Opt the entire schema-registry HTTP-API suite out of CDT: it is exhaustive and | ||
| # adds significant runtime on real cloud infra without adding any cloud-infra | ||
| # coverage (the dockerized CI run already exercises it end to end). The test | ||
| # methods live on the base classes above; skip_file_in_cdt marks each module | ||
| # class's own methods, so the thin concrete subclasses inherit the mark. | ||
| skip_file_in_cdt( | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A module-scope opt-out also pulls in Is opting the transport-stress tests out of CDT intentional? If so, a one-line note in the accounting justifying it would help; if not, consider a method-scope |
||
| reason="exhaustive SR HTTP-API suite; no cloud-infra signal (dockerized CI covers it)" | ||
| ) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A module-scope opt-out also pulls in
SchemaRegistryTransportStressTest(and its*RpcTransport*/*KafkaClientTransport*subclasses), which does concurrent SR read/write while transferring leadership of_schemasto check resilience under real network/timing. That is arguably one of the SR tests where real EC2 (vs. loopback docker) network + scheduling behavior does add signal, unlike the pure HTTP-API surface the PR body describes.Is opting the transport-stress tests out of CDT intentional? If so, a one-line note in the accounting justifying it would help; if not, consider a method-scope
@skip_in_cdton the HTTP-API methods instead of a whole-file opt-out, so the resilience tests keep their real-hardware coverage.