-
Notifications
You must be signed in to change notification settings - Fork 763
[CORE-16608] cluster_link: validate source SR reachability and target emptiness on link creation #31011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mnajda-redpanda
wants to merge
5
commits into
redpanda-data:dev
Choose a base branch
from
mnajda-redpanda:mnajda/pre-link-creation-validation-checks
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,086
−47
Open
[CORE-16608] cluster_link: validate source SR reachability and target emptiness on link creation #31011
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3ed7d0d
schema: add has_subjects to the registry interface
mnajda-redpanda 4766575
schema: add get_subjects to the registry interface
mnajda-redpanda 3883449
cluster_link: extract shared SR context-mapping predicate
mnajda-redpanda be8b85c
cluster_link: validate SR reachability and target emptiness on link c…
mnajda-redpanda 51f1e07
ducktape: end-to-end shadow-link SR preflight ducktape
mnajda-redpanda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| /* | ||
| * Copyright 2026 Redpanda Data, Inc. | ||
| * | ||
| * Use of this software is governed by the Business Source License | ||
| * included in the file licenses/BSL.md | ||
| * | ||
| * As of the Change Date specified in that file, in accordance with | ||
| * the Business Source License, use of this software will be governed | ||
| * by the Apache License, Version 2.0 | ||
| */ | ||
|
|
||
| #include "cluster_link/model/sr_context_mapping.h" | ||
|
|
||
| #include <algorithm> | ||
|
|
||
| namespace cluster_link::model { | ||
|
|
||
| bool filter_selects_source_context( | ||
| const schema_registry_sync_config::source_filter& filter, | ||
| const pandaproxy::schema_registry::context& source_context) { | ||
| namespace ppsr = pandaproxy::schema_registry; | ||
| // An empty filter selects every source context. | ||
| if (filter.contexts.empty() && filter.subjects.empty()) { | ||
| return true; | ||
| } | ||
| if (std::ranges::contains(filter.contexts, source_context())) { | ||
| return true; | ||
| } | ||
| return std::ranges::any_of( | ||
| filter.subjects, [&source_context](const auto& subject) { | ||
| const auto parsed = ppsr::context_subject::from_string( | ||
| subject, ppsr::qualified_subjects_enabled::yes); | ||
| return parsed.ctx == source_context; | ||
| }); | ||
| } | ||
|
|
||
| } // namespace cluster_link::model |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* | ||
| * Copyright 2026 Redpanda Data, Inc. | ||
| * | ||
| * Use of this software is governed by the Business Source License | ||
| * included in the file licenses/BSL.md | ||
| * | ||
| * As of the Change Date specified in that file, in accordance with | ||
| * the Business Source License, use of this software will be governed | ||
| * by the Apache License, Version 2.0 | ||
| */ | ||
|
|
||
| #pragma once | ||
|
|
||
| #include "cluster_link/model/types.h" | ||
| #include "pandaproxy/schema_registry/types.h" | ||
|
|
||
| namespace cluster_link::model { | ||
|
|
||
| /// Returns true if the API-sync source filter selects \p source_context. | ||
| /// | ||
| /// An empty filter (no contexts and no subjects) selects every source context. | ||
| /// This is the single source of truth for filter membership, shared by the | ||
| /// runtime client-write blocker (cluster/cluster_link/frontend.cc) and the | ||
| /// creation-time Schema Registry preflight check | ||
| /// (cluster_link/sr_preflight_checker.cc) so the two cannot drift. | ||
| bool filter_selects_source_context( | ||
| const schema_registry_sync_config::source_filter& filter, | ||
| const pandaproxy::schema_registry::context& source_context); | ||
|
|
||
| } // namespace cluster_link::model | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for splitting this into a separate commit 🚀