Fixes for smaller issues - #192
Merged
Merged
Conversation
If multiple configs were given and more than one defined a subkey of the same dict, the whole key would be overwritten. Example: [foo] bar = 1 baz = 2 [foo] bar = 3 This would overwrite the whole `foo` dictionary, removing the `baz` key which is not the intuitive. With this fix, the toml files are recursively merged so only specified keys in subsequent config files are overwritten (or added if not defined in the first config). Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Pull Request Test Coverage Report for Build 17860027532Details
💛 - Coveralls |
naddinadja
changed the title
naddinadja
force-pushed
the
config
branch
2 times, most recently
from
September 9, 2025 12:13
d1832eb to
390bada
Compare
This script waits for the SSH to be ready in a qemu guest. This is useful if a guest is started without the provided `qemu.guest_start` script. Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
Windows qcow2 images do not use the virtio-blk-pci driver for booting virtual machines so this commit allows the user to define a boot driver under the key `qemu.guests.<name>.boot_driver`, and defaults to the original `virtio-blk-pci` driver if none is specified. Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
naddinadja
force-pushed
the
config
branch
7 times, most recently
from
September 19, 2025 13:29
e3755a9 to
aca85c8
Compare
This is necessary for the debian arm image to not rerun cloud-init again and again in the qemu.guest_aarch64 example. Signed-off-by: Nadja Brix Koch <n.koch@samsung.com>
safl
approved these changes
Sep 20, 2025
safl
left a comment
safl
left a comment
Collaborator
There was a problem hiding this comment.
This is great!l functionality and a very nice fix on cloud-init. Lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for:
Added: