Re-iteration of #194 - #196
Merged
Merged
Conversation
Incident https://www.githubstatus.com/incidents/071h21gptcp0 resolved, thus reverting commit 51a00ee.
safl
force-pushed
the
wait_for_transport
branch
from
October 2, 2025 07:27
4b5fb20 to
5633d09
Compare
safl
changed the title
safl
force-pushed
the
wait_for_transport
branch
from
October 2, 2025 07:35
5633d09 to
c478b52
Compare
Pull Request Test Coverage Report for Build 18187184696Details
💛 - Coveralls |
karlowich
approved these changes
Oct 2, 2025
karlowich
left a comment
karlowich
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Avoided hangs from Paramiko sounds great!
The `wait_for_ssh` script previously only checked whether the target was *up*. This could cause false positives during reboots, since a rebooting target might still appear as reachable at the time of the check. To improve reliability: - The script can now check for both *up* and *down* states. - A raw socket probe is used instead of Paramiko to avoid hangs. Signed-off-by: Simon A. F. Lund <os@safl.dk>
safl
force-pushed
the
wait_for_transport
branch
from
October 2, 2025 08:07
c478b52 to
3a423b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another iteration on #194
Along with a revert of disabling checks of macos runners