Skip to content

fix: define error timestamps as ISO datetimes #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luwqz1 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: define error timestamps as ISO datetimes #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/common/utils/startup-app/extra-models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ const internalServerErrors = Object.values(ERRORS).filter(

export class RemnawaveNotFoundErrorDto extends createZodDto(
z.object({
timestamp: z.string().describe('Time when the error occurred, in ISO 8601 format.'),
timestamp: z.iso
.datetime({ local: true, offset: true })
.describe('Time when the error occurred, in ISO 8601 format.'),
path: z.string().describe('Path of the request that caused the error.'),
message: z
.enum(notFoundErrors.map((error) => error.message) as [string, ...string[]])
Expand All @@ -70,7 +72,9 @@ export class RemnawaveNotFoundErrorDto extends createZodDto(

export class RemnawaveBadRequestErrorDto extends createZodDto(
z.object({
timestamp: z.string().describe('Time when the error occurred, in ISO 8601 format.'),
timestamp: z.iso
.datetime({ local: true, offset: true })
.describe('Time when the error occurred, in ISO 8601 format.'),
path: z.string().describe('Path of the request that caused the error.'),
message: z
.enum(badRequestErrors.map((error) => error.message) as [string, ...string[]])
Expand Down Expand Up @@ -106,7 +110,9 @@ export class RemnawaveValidationErrorDto extends createZodDto(

export class RemnawaveInternalServerErrorDto extends createZodDto(
z.object({
timestamp: z.string().describe('Time when the error occurred, in ISO 8601 format.'),
timestamp: z.iso
.datetime({ local: true, offset: true })
.describe('Time when the error occurred, in ISO 8601 format.'),
path: z.string().describe('Path of the request that caused the error.'),
message: z
.enum(internalServerErrors.map((error) => error.message) as [string, ...string[]])
Expand Down