Closed
Conversation
optionally glides an existing note to the specified target pitch instead of starting a new note
- run previous sequences for an entire pattern length or up to 4 steps to look past possible glided notes - memorize time where a note *will* stop so note glides can check if a note is playing or will be stopped
... and update samples to next phrase when time bases change
... it's already exported in the prelude and is necessary in order to create completely custom or fallback patterns
- build with `fwasm-exceptions` to fix build errors with recent rustc/emscripten compilers - update lua-src-rs accordingly
* separate cycle tests * variable values & targets in cycle * inject `Parameter` values into `Cycle` as vars, parsing enum strings as "sub-cycle" expressions * perf tweaks
Benchmark for 3b35d45Click to view benchmark
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An initial draft for the discussed
varsfunction on the cycle object.Works similar to
mapin that you can supply either a static table or a function returning a table.I guess we'll need a different context for vars? Since variables are only being assigned once per generate instead of each event, the fields related to a single step are meaningless.
Currently the table variant directly inserts the variables to the cycle instead of passing around the table contrary to the case with
map, whereas the callback variant follows a similar pattern to themapping_function.Not sure what else should happen with the callback and its errors here, but it seems to work fine so far.