array-like access syntax for subdivisions and alternating#111
Draft
unlessgames wants to merge 1 commit intodevfrom
Draft
array-like access syntax for subdivisions and alternating#111unlessgames wants to merge 1 commit intodevfrom
unlessgames wants to merge 1 commit intodevfrom
Conversation
Benchmark for 8e03014Click to view benchmark
|
Member
|
Works great. And is super fun in combination with the new variables to in order to dynamically select sub sequences, too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing #108
Subdivisons work as described in the issue. Being able to use patterns on the right side for this proved to be super handy for experimentation in my opinion, see examples in the tests.
pattrns/src/tidal/cycle/tests.rs
Lines 75 to 93 in 82bc6a6
For alternating patterns
<..>I went with using the index as an offset instead of a static access, so it still plays the inner steps across cycles but with an offset for where to start which seems like reasonable behaviour but there might be something better to do here, and while indexing from1is natural, using the same value for offsetting (ie1being no offset) is a bit less so.