Skip to content

Change read visibility of PickleId property to public. #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
clrudolphi wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Change read visibility of PickleId property to public. #1050

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fa2294
Change visibility of PickleId property to public.
clrudolphi Feb 26, 2026
ae66000
Revised to Public get; internal set;
clrudolphi Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

## Bug fixes:
* Fix: Formatters incorrectly handle Unicode text file content of attachments.
* Enhancement: Changed visibility of PickleId property of ScenarioInfo to public.
Copy link
Copy Markdown
Member

@304NotModified 304NotModified Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be under Improvements by the way. (And maybe mention "read")


*Contributors of this release (in alphabetical order):* @clrudolphi

Expand Down
2 changes: 1 addition & 1 deletion Reqnroll/ScenarioInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public class ScenarioInfo
/// <summary>
/// This holds the unique identifier for the test ("pickle") represented by this scenario info. Used internally at runtime.
/// </summary>
internal string PickleId { get; set; }
public string PickleId { get; set; }
Copy link
Copy Markdown
Member

@304NotModified 304NotModified Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent read the full discussion. But is also a public setter needed?



public ScenarioInfo(string title, string description, string[] tags, IOrderedDictionary arguments, string[] inheritedTags = null, string pickleIndex = null)
Expand Down
Loading