Skip to content

Fix creating SpecFlow compat package (v3.x) #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
304NotModified wants to merge 4 commits into
base: product-lines/v3
Choose a base branch
from
+8 −3
Open

Fix creating SpecFlow compat package (v3.x) #1070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c3209be
IsPackable to true for SpecFlow compat package
304NotModified Mar 26, 2026
0f2339c
update CHANGELOG
gasparnagy May 21, 2026
90c0d70
Setting the target framework even for SpecFlowCompatibility plugin PD…
gasparnagy May 22, 2026
b27657d
Add comments for better understandability
gasparnagy May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@

## Bug fixes:

*Contributors of this release (in alphabetical order):*
* Fix: Reqnroll.SpecFlowCompatibility 3.3.4 package is not published (#1068)

*Contributors of this release (in alphabetical order):* @304NotModified

# v3.3.4 - 2026-03-23

Expand Down
3 changes: 3 additions & 0 deletions Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,12 +140,15 @@ if (Directory.Exists(TmpDirectory))
<!-- Included referenced project PDBs as part of the symbols package. -->
<Target Name="CollectProjectReferenceDebugSymbolsForPack" DependsOnTargets="$(CollectProjectReferenceDebugSymbolsForPackDependsOn)">
<ItemGroup>
<!-- Include symbols for PDB files in _ProjectReferenceCopyLocalPathsForPackAsComponent -->
<TfmSpecificDebugSymbolsFile
Include="@(_ProjectReferenceCopyLocalPathsForPackAsComponent)"
TargetFramework="$(TargetFramework)"
Condition="'%(Extension)' == '.pdb'"/>
</ItemGroup>

<ItemGroup>
<!-- Include related PDB symbols for DLL files in _ProjectReferenceCopyLocalPathsForPackAsComponent -->
<_TfmSpecificDebugSymbolsCandidate
Include="@(_ProjectReferenceCopyLocalPathsForPackAsComponent->'%(RootDir)%(Directory)%(Filename).pdb')"
Condition="'%(Extension)' != '.pdb'"/>
Expand Down
4 changes: 2 additions & 2 deletions ...SpecFlowCompatibility.ReqnrollPlugin/Reqnroll.SpecFlowCompatibility.ReqnrollPlugin.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<PropertyGroup>
<TargetFrameworks>netstandard2.0;net462</TargetFrameworks>
<IsReqnrollRuntimePlugin>true</IsReqnrollRuntimePlugin>
<IsPackable>false</IsPackable>
<IsPackable>true</IsPackable>

<!-- This is required to ensure dependencies are made available for packing -->
<CopyLocalLockFileAssemblies>true</CopyLocalLockFileAssemblies>
Expand All @@ -21,4 +21,4 @@
<ProjectReference Include="..\Reqnroll.SpecFlowCompatibility\Reqnroll.SpecFlowCompatibility.csproj" PrivateAssets="all" PackAsComponent="true" />
</ItemGroup>

</Project>
</Project>
Loading