Skip to content

new cvxETH+ETH plugin on migrated pool - #1251

Merged
tbrent merged 19 commits into
4.0.0from
cvx-ethplus-eth
Aug 15, 2025
Merged

new cvxETH+ETH plugin on migrated pool#1251
tbrent merged 19 commits into
4.0.0from
cvx-ethplus-eth

Conversation

@tbrent

@tbrent tbrent commented Jul 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Three changes from previous cvxETH+ETH plugin:

  1. The new pool has an internal exchange rate oracle for ETH+, so it embeds the RToken appreciation within the virtual
    price for us already
  2. The new pool's token is worth half as much as the previous one. They don't use the x2 rule when it comes to these StableSwapNGs, it looks like.
  3. The new pool isn't susceptible to reentrancy, because its on pure WETH as opposed to ETH. Still, we can check for reentrancy cheaply with totalSupply() in CryptoSwapNG 7.0.0, so I do so

Wow, looks like chainlink changed the oracleTimeout of USDP on us. Need to remember to re-deploy the following plugins: USDP, aUSDP, cUSDP, yvCurveUSDPcrvUSD

CI changed to use latest block so we catch issues like this faster in the future

@tbrent
tbrent requested a review from julianmrodri July 29, 2025 23:09
akshatmittal
akshatmittal reviewed Jul 30, 2025
View reviewed changes
Comment thread contracts/plugins/assets/curve/CurveAppreciatingRTokenFiatCollateral.sol Outdated
julianmrodri
julianmrodri reviewed Jul 30, 2025
View reviewed changes

@julianmrodri julianmrodri left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments Would like to re-review once tests are running to do some value checks.

Comment thread contracts/plugins/assets/curve/CurveAppreciatingRTokenFiatCollateral.sol
Comment thread contracts/plugins/assets/curve/CurveAppreciatingRTokenFiatCollateral.sol Outdated
Comment thread test/integration/fork-block-numbers.ts
Comment thread test/plugins/individual-collateral/curve/cvx/CvxAppreciatingRTokenSelfReferential.test.ts
@tbrent tbrent changed the title implement + test new cvxETH+ETH plugin on migrated pool new cvxETH+ETH plugin on migrated pool Aug 5, 2025
julianmrodri
julianmrodri approved these changes Aug 11, 2025
View reviewed changes

@julianmrodri julianmrodri left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Its missing the verification scripts fix for the modified deployment scripts. I can add them.

Comment thread test/plugins/individual-collateral/curve/cvx/CvxAppreciatingRTokenSelfReferential.test.ts Outdated
pmckelvy1
pmckelvy1 approved these changes Aug 15, 2025
View reviewed changes

@pmckelvy1 pmckelvy1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tbrent
tbrent merged commit a0252ed into 4.0.0 Aug 15, 2025
15 checks passed
@tbrent
tbrent deleted the cvx-ethplus-eth branch August 15, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akshatmittal akshatmittal akshatmittal left review comments
@pmckelvy1 pmckelvy1 pmckelvy1 approved these changes
@julianmrodri julianmrodri julianmrodri approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tbrent @akshatmittal @pmckelvy1 @julianmrodri