fix(governance): use vault chain for vote-lock logos - #1092
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe vote-lock component now uses ChangesGovernance vote-lock chain identity
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The governance vote-lock UI now resolves token logos using the vault’s chain, correcting cross-chain displays while preserving same-chain behavior. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying register-app with
|
| Latest commit: |
7f390c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0144d0b3.register-app.pages.dev |
| Branch Preview URL: | https://fix-vote-lock-vault-chain.register-app.pages.dev |
Summary
Root cause
The governance sidebar passed the global page chain to
TokenLogo. Cross-chain AI DTFs can be displayed on Ethereum while their vlRSR vault is on BNB Chain, so the logo lookup used the wrong chain identity.Verification
pnpm exec oxlint src/views/index-dtf/governance/components/governance-vote-lock.tsxpnpm typecheckEngineer review required: this changes the chain identity used by the governance vote-lock UI.