Skip to content

Expand earn vote-lock FAQ and link rates to it - #1094

Open
lcamargof wants to merge 2 commits into
masterfrom
feature/earn-faq-vote-lock
Open

Expand earn vote-lock FAQ and link rates to it#1094
lcamargof wants to merge 2 commits into
masterfrom
feature/earn-faq-vote-lock

Conversation

@lcamargof

@lcamargof lcamargof commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Expands the Earn → Index DTF Governance FAQ from 3 to 9 questions and connects the table's APY/APR figures to it.

FAQ content

  • Full question set: what vote-locking is, how rewards flow (vlRSR-style automatic vs claimable), why rewards stream, APY vs APR, how the displayed rate is calculated, why realized returns differ, shared vaults, voting requirements, and unlocking.
  • Fixes the old unlock answer, which claimed early unlocks are not allowed — the new copy matches the actual flow (begin anytime, wait the vault's unlock delay, rewards stop accruing once unlock starts).
  • Inline diagrams for the reward flows, streaming timeline, rate formula, and estimate-vs-realized comparison, built from design tokens with light/dark support, capped at a fixed width and centered.

Rate → FAQ deep link

  • A help icon next to each APY/APR value scrolls to the FAQ and opens the rate-calculation question. Row click-through to the lock drawer is unaffected.
  • EarnMetricCtaCell and EarnFAQ gain optional props only; defaults unchanged for the other earn tabs.

Instrumentation & i18n

  • FAQ opens tracked as tap with faq_<question> ctas; the help icon as rate_help.
  • All new strings translated in es/ko/zh; catalogs extract clean with 0 missing.

Also included (separate commit): refresh of the llm-workflow kit — 18 new agent skills, updated router, kit-owned templates, and AGENTS.md-aware area-guide detection in scope.mjs. Docs/tooling only, no app code.

Replace the 3-question earn Index DTF FAQ with a 9-question set covering
reward mechanics, streaming, APY vs APR, rate calculation, and unlock
behavior, with inline diagrams built from design tokens. The old unlock
answer claimed early unlocks are not allowed; the new copy matches the
actual begin-anytime unlock delay flow.

Add a help icon next to each APY/APR rate that scrolls to the FAQ and
opens the rate-calculation question. FAQ opens and the help icon are
tracked as tap events. All new strings translated (es/ko/zh).
@lcamargof
lcamargof force-pushed the feature/earn-faq-vote-lock branch from 3f9b7cc to 8bd4f33 Compare August 20, 2026 18:04
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 20, 2026

Copy link
Copy Markdown

Deploying register-app with  Cloudflare Pages  Cloudflare Pages

Latest commit: 017dcad
Status: ✅  Deploy successful!
Preview URL: https://f1564575.register-app.pages.dev
Branch Preview URL: https://feature-earn-faq-vote-lock.register-app.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@lcamargof, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5498c606-4904-4e41-ad4e-1aef6808bb73

📥 Commits

Reviewing files that changed from the base of the PR and between 1251ac1 and 017dcad.

📒 Files selected for processing (56)
  • CLAUDE.md
  • docs/wiki/log.md
  • docs/wiki/progress.md
  • scripts/llm-workflow/lib/core.mjs
  • skills/adopt.md
  • skills/architecture-review.md
  • skills/codebase-deep-scan.md
  • skills/create-verification.md
  • skills/debugging.md
  • skills/design.md
  • skills/evaluate-workflow.md
  • skills/experience-design.md
  • skills/foundation-review.md
  • skills/maintain-verification.md
  • skills/model-capabilities.md
  • skills/pair-protocol.md
  • skills/pair-reviewer.md
  • skills/pair.md
  • skills/planning.md
  • skills/release-evidence.md
  • skills/resolving-merge-conflicts.md
  • skills/resume-work.md
  • skills/scar-mining.md
  • skills/stage.md
  • skills/taste.md
  • skills/testing.md
  • skills/topology.md
  • skills/ui-ux.md
  • skills/wayfinder.md
  • skills/wiki.md
  • skills/workflow.md
  • src/locales/en.po
  • src/locales/es.po
  • src/locales/ko.po
  • src/locales/zh.po
  • src/views/earn/components/earn-faq.tsx
  • src/views/earn/components/earn-table-cells.tsx
  • src/views/earn/views/index-dtf/atoms.ts
  • src/views/earn/views/index-dtf/components/faq-graphics.tsx
  • src/views/earn/views/index-dtf/components/faq.tsx
  • src/views/earn/views/index-dtf/components/vote-lock-positions.tsx
  • src/views/earn/views/index-dtf/index.tsx
  • templates/design/brief.md
  • templates/design/candidate.md
  • templates/design/synthesis.md
  • templates/evaluation/capability-profile.md
  • templates/evaluation/held-out-rubric.md
  • templates/evaluation/plan.md
  • templates/evaluation/run-record.md
  • templates/evaluation/verdict.md
  • templates/evidence/release-receipt.template.md
  • templates/evidence/resume-checkpoint.template.md
  • templates/verification/evidence.template.md
  • templates/verification/features/README.template.md
  • templates/verification/features/feature.template.md
  • templates/verification/verify-surface.template.md
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/earn-faq-vote-lock

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Kit update from agent-workflow @ b0da65a: 18 new skills (staged-work
machinery split into stage.md, review/verification/pairing skills),
router updated to route them, kit-owned templates now shipped in-repo,
and area-guide drift detection made AGENTS.md-aware.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant