-
Notifications
You must be signed in to change notification settings - Fork 17
Add BED and SMEL deprecation proposals #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
julianmrodri
wants to merge
5
commits into
main
Choose a base branch
from
new-deprecations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
cc50c40
Add BED and SMEL deprecation proposals
julianmrodri 7886855
Share deprecation fork test logic in a base contract
julianmrodri adfde23
Guard against topic-less logs when finding the unstaking lock
julianmrodri 5195f7a
Validate the live BED and SMEL proposals through their full lifecycle
julianmrodri 82528a8
Cover the queued BED and SMEL proposals
julianmrodri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "version": "1.0", | ||
| "chainId": "1", | ||
| "createdAt": 1786449741, | ||
| "meta": { | ||
| "name": "Deprecate BED", | ||
| "description": "Governance proposal to deprecate BED Index DTF" | ||
| }, | ||
| "transactions": [ | ||
| { | ||
| "to": "0xfad4823ae478637fd8ffdafb6c912f63c8cd1dd7", | ||
| "value": "0", | ||
| "data": "0x7d5e81e2000000000000000000000000000000000000000000000000000000000000008000000000000000000000000000000000000000000000000000000000000001800000000000000000000000000000000000000000000000000000000000000280000000000000000000000000000000000000000000000000000000000000068000000000000000000000000000000000000000000000000000000000000000070000000000000000000000004e3b170dcbe704b248df5f56d488114ace01b1c50000000000000000000000004e3b170dcbe704b248df5f56d488114ace01b1c50000000000000000000000004e3b170dcbe704b248df5f56d488114ace01b1c50000000000000000000000004e3b170dcbe704b248df5f56d488114ace01b1c50000000000000000000000004e3b170dcbe704b248df5f56d488114ace01b1c50000000000000000000000004e3b170dcbe704b248df5f56d488114ace01b1c5000000000000000000000000eaa356f6cd6b3fd15b47838d03cf34fa79f7c71200000000000000000000000000000000000000000000000000000000000000070000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000700000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000012000000000000000000000000000000000000000000000000000000000000001a0000000000000000000000000000000000000000000000000000000000000022000000000000000000000000000000000000000000000000000000000000002a0000000000000000000000000000000000000000000000000000000000000032000000000000000000000000000000000000000000000000000000000000003a000000000000000000000000000000000000000000000000000000000000000047aeaafb3000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044d547741f4ff6ae4d6a29e79ca45c6441bdc89b93878ac6118485b33c8baa3749fc3cb1300000000000000000000000008e530cd0c47d515558229aae193dd119cc791a40000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044d547741f13ff1b2625181b311f257c723b5e6d366eb318b212d9dd694c48fcf227659df5000000000000000000000000280730d9277ef586d58db74c277aa710ca8f87c9000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044d547741f13ff1b2625181b311f257c723b5e6d366eb318b212d9dd694c48fcf227659df5000000000000000000000000c6625129c9df3314a4dd604845488f4ba62f9db8000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044d547741f13ff1b2625181b311f257c723b5e6d366eb318b212d9dd694c48fcf227659df50000000000000000000000007daaf7bc2ee8bf4c0ac7f37e6b6cfaeb3ed9a868000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044d547741f00000000000000000000000000000000000000000000000000000000000000000000000000000000000000006b45fe3f4464477f657702b8e942b71c3ba83944000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000004715018a60000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000174465707265636174652042454420496e64657820445446000000000000000000" | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| { | ||
| "version": "1.0", | ||
| "chainId": "1", | ||
| "createdAt": 1786449741, | ||
| "meta": { | ||
| "name": "Deprecate SMEL", | ||
| "description": "Governance proposal to deprecate SMEL Index DTF" | ||
| }, | ||
| "transactions": [ | ||
| { | ||
| "to": "0x622c0b5ad82a2a47f330d4a2061a0e3562f583b0", | ||
| "value": "0", | ||
| "data": "0x7d5e81e200000000000000000000000000000000000000000000000000000000000000800000000000000000000000000000000000000000000000000000000000000180000000000000000000000000000000000000000000000000000000000000028000000000000000000000000000000000000000000000000000000000000006800000000000000000000000000000000000000000000000000000000000000007000000000000000000000000f91384484f4717314798e8975bcd904a35fc2bf1000000000000000000000000f91384484f4717314798e8975bcd904a35fc2bf1000000000000000000000000f91384484f4717314798e8975bcd904a35fc2bf1000000000000000000000000f91384484f4717314798e8975bcd904a35fc2bf1000000000000000000000000f91384484f4717314798e8975bcd904a35fc2bf1000000000000000000000000f91384484f4717314798e8975bcd904a35fc2bf1000000000000000000000000dd885b0f2f97703b94d2790320b30017a17768bf00000000000000000000000000000000000000000000000000000000000000070000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000700000000000000000000000000000000000000000000000000000000000000e0000000000000000000000000000000000000000000000000000000000000012000000000000000000000000000000000000000000000000000000000000001a0000000000000000000000000000000000000000000000000000000000000022000000000000000000000000000000000000000000000000000000000000002a0000000000000000000000000000000000000000000000000000000000000032000000000000000000000000000000000000000000000000000000000000003a000000000000000000000000000000000000000000000000000000000000000047aeaafb3000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044d547741f4ff6ae4d6a29e79ca45c6441bdc89b93878ac6118485b33c8baa3749fc3cb130000000000000000000000000395417220ae7447d19752f38327b96faf52e1911000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044d547741f13ff1b2625181b311f257c723b5e6d366eb318b212d9dd694c48fcf227659df5000000000000000000000000280730d9277ef586d58db74c277aa710ca8f87c9000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044d547741f13ff1b2625181b311f257c723b5e6d366eb318b212d9dd694c48fcf227659df5000000000000000000000000c6625129c9df3314a4dd604845488f4ba62f9db8000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044d547741f13ff1b2625181b311f257c723b5e6d366eb318b212d9dd694c48fcf227659df50000000000000000000000007daaf7bc2ee8bf4c0ac7f37e6b6cfaeb3ed9a868000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000044d547741f0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000476ae35b6deccda7969f105e983a916bcc12c31a000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000004715018a600000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000001844657072656361746520534d454c20496e646578204454460000000000000000" | ||
| } | ||
| ] | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Fix the garbled redeem sentence.
The phrase "every token
toAssetsquotes a nonzero amount for must pay out" is not readable. It documents the exact assertion in_assertRedeemStillWorks, so the wording should be precise.📝 Proposed wording
📝 Committable suggestion
🤖 Prompt for AI Agents