Fix decimals - #4
Open
pmckelvy1 wants to merge 2 commits into
Open
Conversation
akshatmittal
requested changes
Oct 18, 2024
|
|
||
| ## WARNING | ||
|
|
||
| ** When deploying GenericStakedAppreciatingVault, make sure to mint some initial dust (at least 1e4), to avoid an inflation attack. ** |
Member
There was a problem hiding this comment.
Clarify that this is only required for large assets where manipulation is profitable with a 0 decimal offset. The vault internally already uses virtual assets and shares making it not profitable for most assets even with a 0 decimal offset.
(Also, nit, remove the excess bolding and capitalization and use code markers for contract names and symbols)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initially tried to add a 2e18 mint in the constructor of GenericStakedAppreciatingVault.
this caused a rather large headache in fixing the tests.
opted instead to just leave out the constructor mint, and add a comment to the README.
lmk if anyone sees a serious technical issue with this.