Skip to content

Reintroduce re-exports in rhai::plugin#1099

Merged
schungx merged 2 commits into
rhaiscript:mainfrom
Abendrill:issue/1098
May 29, 2026
Merged

Reintroduce re-exports in rhai::plugin#1099
schungx merged 2 commits into
rhaiscript:mainfrom
Abendrill:issue/1098

Conversation

@Abendrill

Copy link
Copy Markdown
Contributor

This PR re-introduce some re-exports that were removed from rhai::plugin in 1.25.0.

This removal was an unintended breaking change despite the items still being available, since dependent crates may have used this import path. In-fact, this did break apollo-router when used as a library.

Fixes #1098

@schungx

schungx commented May 28, 2026

Copy link
Copy Markdown
Collaborator

The formatting CI is failing... Perhaps you need to do a cargo fmt.

@Abendrill

Copy link
Copy Markdown
Contributor Author

My bad, I've applied formatting now.

❗ Also two ui_tests failed. rustc decided to use std::iter::Iterator instead of just Iterator. I'm not sure why. I just opted to update the expected output. Are you @schungx ok with this?

@schungx

schungx commented May 28, 2026

Copy link
Copy Markdown
Collaborator

I think you should remove the fixes to the unrelated tests as it'd just clutter up the PR.

I'd put in another PR later on to fix the test outputs.

Don't worry if they fail at this point.

@Abendrill

Copy link
Copy Markdown
Contributor Author

Alright, will do.

@schungx

schungx commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Yes because Rust 1.90 has just come out and there would be more test outputs that need to update anyway.

@Abendrill

Copy link
Copy Markdown
Contributor Author

Removed the ui_test changes now!

@schungx schungx merged commit 4b7eeb5 into rhaiscript:main May 29, 2026
79 of 83 checks passed
@Abendrill

Copy link
Copy Markdown
Contributor Author

Thanks for quick and responsive collab @schungx! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot Compile with Rhai 1.25.0 Version 1.25.0 had undocumented breaking change could not be complied with new version of rhai

2 participants