Reintroduce re-exports in rhai::plugin#1099
Merged
Merged
Conversation
Collaborator
|
The formatting CI is failing... Perhaps you need to do a |
Contributor
Author
|
My bad, I've applied formatting now. ❗ Also two ui_tests failed. rustc decided to use |
Collaborator
|
I think you should remove the fixes to the unrelated tests as it'd just clutter up the PR. I'd put in another PR later on to fix the test outputs. Don't worry if they fail at this point. |
Contributor
Author
|
Alright, will do. |
Collaborator
|
Yes because Rust 1.90 has just come out and there would be more test outputs that need to update anyway. |
This was
linked to
issues
May 29, 2026
Contributor
Author
|
Removed the ui_test changes now! |
Contributor
Author
|
Thanks for quick and responsive collab @schungx! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-introduce some re-exports that were removed from
rhai::pluginin 1.25.0.This removal was an unintended breaking change despite the items still being available, since dependent crates may have used this import path. In-fact, this did break
apollo-routerwhen used as a library.Fixes #1098