Skip to content

Disable rhel autoconnections on bootif r9 - #6344

Merged
M4rtinK merged 2 commits into
rhinstaller:rhel-9from
rvykydal:disable-rhel-autoconnections-on-bootif-r9
Apr 16, 2025
Merged

Disable rhel autoconnections on bootif r9#6344
M4rtinK merged 2 commits into
rhinstaller:rhel-9from
rvykydal:disable-rhel-autoconnections-on-bootif-r9

Conversation

@rvykydal

@rvykydal rvykydal commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

Resolves: RHEL-78272
Port of #6138

@rvykydal rvykydal added the rhel-9 label Apr 9, 2025
@sourcery-ai

sourcery-ai Bot commented Apr 9, 2025

Copy link
Copy Markdown

Reviewer's Guide by Sourcery

This pull request adds a new systemd service, anaconda-nm-disable-autocons-rhel.service, to disable NetworkManager autoconnections specifically on RHEL systems during the anaconda installer process. This mirrors functionality already present for other systems, now tailored for RHEL.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Added a new systemd service to disable NetworkManager autoconnections on RHEL systems.
  • Added a new systemd service file.
  • Added the new service to the list of installed systemd services.
data/systemd/Makefile.am
data/systemd/anaconda-nm-disable-autocons-rhel.service

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@rvykydal

rvykydal commented Apr 9, 2025

Copy link
Copy Markdown
Contributor Author

/kickstart-test --testtype smoke

@rvykydal

rvykydal commented Apr 9, 2025

Copy link
Copy Markdown
Contributor Author

/kickstart-test network-autoconnections-httpks

@rvykydal

rvykydal commented Apr 11, 2025

Copy link
Copy Markdown
Contributor Author

The patches were cleaned up and squashed in #6258, I'll open new pull request for rhel-9 branch.

@rvykydal rvykydal closed this Apr 11, 2025
@rvykydal rvykydal reopened this Apr 11, 2025
@rvykydal

rvykydal commented Apr 11, 2025

Copy link
Copy Markdown
Contributor Author

The patches were cleaned up and squashed in #6258, I'll open new pull request for rhel-9 branch.

Ah, that was meant for another PR, sorry.

@rvykydal

Copy link
Copy Markdown
Contributor Author

/kickstart-test --testtype smoke

@rvykydal

Copy link
Copy Markdown
Contributor Author

/kickstart-test network-autoconnections-httpks

@rvykydal
rvykydal marked this pull request as ready for review April 11, 2025 11:21
@rvykydal
rvykydal requested review from jkonecny12 and jstodola April 11, 2025 11:21

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rvykydal - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider including a brief explanation of why this change is necessary.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jkonecny12 jkonecny12 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however, aren't we missing

ConditionOSRelease=ID=rhel

on the systemd unit. Or is this condition missing no RHEL-9?

@rvykydal

rvykydal commented Apr 11, 2025

Copy link
Copy Markdown
Contributor Author

Looks good to me, however, aren't we missing

ConditionOSRelease=ID=rhel

on the systemd unit. Or is this condition missing no RHEL-9?

It wouldn't work for centos so for rhel-9 I'd keep it as it is. For upstream / RHEL10 we'll be adding this: #6142 in scope of https://issues.redhat.com/browse/RHEL-67815. But since we are using special rhel branches there is actually no need for the patch in rhel-9 (and in rhel-10 neither but I think we should be consistent with upstream there - at least to keep it working, given we can't count on ELN much in that).

@rvykydal rvykydal added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Apr 15, 2025
@M4rtinK
M4rtinK merged commit ddb59a6 into rhinstaller:rhel-9 Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-9

Development

Successfully merging this pull request may close these issues.

4 participants