Disable rhel autoconnections on bootif r9 - #6344
Conversation
Related: RHEL-78272
Resolves: RHEL-78272
Reviewer's Guide by SourceryThis pull request adds a new systemd service, No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
/kickstart-test --testtype smoke |
|
/kickstart-test network-autoconnections-httpks |
|
|
Ah, that was meant for another PR, sorry. |
|
/kickstart-test --testtype smoke |
|
/kickstart-test network-autoconnections-httpks |
There was a problem hiding this comment.
Hey @rvykydal - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider including a brief explanation of why this change is necessary.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
jkonecny12
left a comment
There was a problem hiding this comment.
Looks good to me, however, aren't we missing
ConditionOSRelease=ID=rhel
on the systemd unit. Or is this condition missing no RHEL-9?
It wouldn't work for centos so for rhel-9 I'd keep it as it is. For upstream / RHEL10 we'll be adding this: #6142 in scope of https://issues.redhat.com/browse/RHEL-67815. But since we are using special rhel branches there is actually no need for the patch in rhel-9 (and in rhel-10 neither but I think we should be consistent with upstream there - at least to keep it working, given we can't count on ELN much in that). |
Resolves: RHEL-78272
Port of #6138