-
Notifications
You must be signed in to change notification settings - Fork 40
Add manual test for dnsconfd name resolution of kickstart location #1409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rvykydal
wants to merge
1
commit into
rhinstaller:main
Choose a base branch
from
rvykydal:dnsconfd-name-resolution-for-ks-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| # | ||
| # Copyright (C) 2025 Red Hat, Inc. | ||
| # | ||
| # This copyrighted material is made available to anyone wishing to use, | ||
| # modify, copy, or redistribute it subject to the terms and conditions of | ||
| # the GNU General Public License v.2, or (at your option) any later version. | ||
| # This program is distributed in the hope that it will be useful, but WITHOUT | ||
| # ANY WARRANTY expressed or implied, including the implied warranties of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General | ||
| # Public License for more details. You should have received a copy of the | ||
| # GNU General Public License along with this program; if not, write to the | ||
| # Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA | ||
| # 02110-1301, USA. Any Red Hat trademarks that are incorporated in the | ||
| # source code or documentation are not subject to the GNU General Public | ||
| # License and may only be used or replicated with the express permission of | ||
| # Red Hat, Inc. | ||
| # | ||
| # Red Hat Author(s): Radek Vykydal <rvykydal@redhat.com> | ||
|
|
||
| HTTP_SERVER_KS_SCP=fedorapeople.org:public_html/dns-global-exclusive-ks-tls-2.ks | ||
| HTTP_SERVER_KS_GET=rvykydal.fedorapeople.org/dns-global-exclusive-ks-tls-2.ks | ||
|
|
||
| if [ "$1" == "manual" ]; then | ||
| # Create kickstart from templates by running the test in dry run | ||
| sudo containers/runner/launch --dry-run dns-global-exclusive-ks-tls-2 | ||
| # Post the kickstart to the URL resolvable by 1.1.1.1 | ||
| scp data/logs/kstest-list-substituted/dns-global-exclusive-ks-tls-2.ks ${HTTP_SERVER_KS_SCP} | ||
| # Run the test with kickstart fetched from the URL | ||
| sudo containers/runner/launch dns-global-exclusive-ks-tls-2 | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Ignore unused variable parsed out by tooling scripts as test tags metadata | ||
| # shellcheck disable=SC2034 | ||
| TESTTYPE=${TESTTYPE:-"network dns skip-on-rhel manual"} | ||
| KICKSTART_NAME=dns-global-exclusive-tls-2 | ||
|
|
||
| . ${KSTESTDIR}/functions.sh | ||
|
|
||
| kernel_args() { | ||
| . ${tmpdir}/ks_url | ||
| echo ${DEFAULT_BOOTOPTS} rd.net.dns=dns+tls://1.1.1.1#one.one.one.one rd.net.dns-resolve-mode=exclusive rd.net.dns-backend=dnsconfd ip=10.0.2.200::10.0.2.2:255.255.255.0:::none inst.ks=${ks_url} | ||
Check warningCode scanning / ShellCheck SC2154
ks_url is referenced but not assigned.
|
||
| } | ||
|
|
||
| prepare() { | ||
| ks=$1 | ||
| tmpdir=$2 | ||
|
|
||
| # Copy the kickstart to a unique remote location | ||
| #scp $ks ${UNIQUE_HTTP_SERVER_KS_SCP} | ||
|
|
||
| echo ks_url=http://${HTTP_SERVER_KS_GET} > ${tmpdir}/ks_url | ||
| echo "${ks}" | ||
| } | ||
|
|
||
| inject_ks_to_initrd() { | ||
| echo "false" | ||
| } | ||
|
|
||
| additional_runner_args() { | ||
| # Wait for reboot and shutdown of the VM, | ||
| # but exit after the specified timeout. | ||
| echo "--wait $(get_timeout)" | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / ShellCheck
SC2034