Skip to content

add kr holidays #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aanoaa wants to merge 9 commits into
base: master
Choose a base branch
from
Open

add kr holidays #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f388f19
add kr holidays except lunar dates
aanoaa Mar 16, 2021
543e30c
i want use 4 spaces indent rather than TAB
aanoaa Mar 16, 2021
4d0f1ab
implement Sol2Lun(chinese solar)
aanoaa Mar 16, 2021
904123c
add kr.Solar2Lunar converts to Korean lunar calendar
aanoaa Mar 16, 2021
78de12f
Add kr.Lunar2Solar
aanoaa Mar 16, 2021
aae390c
Add `Lunar` attribute to Holiday struct
aanoaa Mar 16, 2021
5637d83
add LunarNewYear Holiday to kr
aanoaa Mar 16, 2021
784f3d6
add test for kr.Lunar holidays
aanoaa Mar 16, 2021
14a5217
add rest of kr holidays
aanoaa Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions v2/holiday.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ type Holiday struct {
Julian bool // the holiday is based on a Julian calendar
Observed []AltDay // the substitution days for the holiday
Func HolidayFn // logic used to determine occurrences
Lunar bool // the holiday is based on a Lunar calendar
Copy link
Copy Markdown
Owner

@rickar rickar Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this used anywhere. Is it needed?

Copy link
Copy Markdown
Author

@aanoaa aanoaa Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some kr holidays uses Lunar flag. such as https://github.com/aanoaa/cal/blob/kr-holidays/v2/kr/kr_holidays.go#L45

}

// Clone returns a copy of the Holiday. If overrides is non-nil, then the
Expand All @@ -71,6 +72,7 @@ func (h *Holiday) Clone(overrides *Holiday) *Holiday {
Offset: h.Offset,
CalcOffset: h.CalcOffset,
Julian: h.Julian,
Lunar: h.Lunar,
Observed: h.Observed,
Func: h.Func,
}
Expand Down
9 changes: 9 additions & 0 deletions v2/kr/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
root = true
Copy link
Copy Markdown
Owner

@rickar rickar Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this file. We use whatever "go fmt" dictates.

Copy link
Copy Markdown
Author

@aanoaa aanoaa Mar 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure i'll patch.


# Unix-style newlines with a newline ending every file
[*]
end_of_line = lf
insert_final_newline = true
charset = utf-8
indent_style = space
indent_size = 4
Loading