Upgrade React to 18, react-router to 7, stylelint to 17#1307
Merged
cybele-ripple merged 52 commits intomainfrom Apr 22, 2026
Merged
Upgrade React to 18, react-router to 7, stylelint to 17#1307cybele-ripple merged 52 commits intomainfrom
cybele-ripple merged 52 commits intomainfrom
Conversation
…lities and associated dependencies
Patel-Raj11
reviewed
Apr 1, 2026
Patel-Raj11
requested changes
Apr 1, 2026
Patel-Raj11
reviewed
Apr 1, 2026
Patel-Raj11
reviewed
Apr 1, 2026
Contributor
|
A dependabot PR #1186 to upgrade stylelint-prettier from 4.1.0 to 5.0.3. I saw that stylelint-prettier upgrade is handled by this PR as well. |
…t-scss-updates # Conflicts: # package-lock.json # package.json
…CursorPaginatedQuery
# Conflicts: # src/containers/Accounts/AMM/AMMAccounts/AMMAccountHeader/test/AMMAccountHeader.test.tsx
- Add PropsWithChildren to React 18 FC components (TooltipProvider, StreamsProvider, VHSValidatorsProvider, SelectedValidatorProvider) - Cast Trans i18next interpolation objects to any in TrustSet/Description and Offer meta renderer to satisfy React 18's stricter children typing - Merge duplicate react-router imports in AccountsRouter - Remove obsolete V7_FUTURE_ROUTER_FLAGS reference (react-router v7 makes this opt-in unnecessary) - Migrate useCursorPaginatedQuery test from deprecated @testing-library/react-hooks to @testing-library/react - Fix package.json prettier formatting
The previous lock file had 90 packages with resolved URLs pointing to artifactory.ops.ripple.com (Ripple's internal Artifactory), which CI runners cannot reach. This caused all four CI jobs (lint, test, build, typescript-check) to fail at the Install Dependencies step. Regenerated by running npm install --registry=https://registry.npmjs.org/ after clearing node_modules and the existing lock.
kuan121
reviewed
Apr 17, 2026
kuan121
reviewed
Apr 17, 2026
Collaborator
|
Can you also update |
Contributor
Author
|
Since this is a very comprehensive update, I have a thorough manual testing plan: Core routes
Network section
Validator detail tabs
Account tabs
Transaction detail tabs
AMM pool tabs
|
kuan121
previously approved these changes
Apr 21, 2026
cybele-ripple
changed the title
The previous commit (React 17→18) downgraded the stylelint stack to v16 because stylelint-config-idiomatic-order@10 pins stylelint-order ^6, which caps stylelint at <17. Pin stylelint-order to ^8.1.1 via an npm override (restoring the pattern from c889aaa) so the rest of the stack can stay on v17. - stylelint ^16.26.1 → ^17.8.0 - stylelint-config-recommended-scss ^14.1.0 → ^17.0.0 - stylelint-config-standard ^36.0.1 → ^40.0.0 - stylelint-order ^6.0.4 → ^8.1.1 (via override) - stylelint-scss ^6.12.1 → ^7.0.0
Contributor
Author
This update is now covered with this commit |
kuan121
approved these changes
Apr 21, 2026
Patel-Raj11
approved these changes
Apr 22, 2026
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR covers updates to
react-routerandstylelint-scssfrom tickets DGE-5422 and DGE-4784 to updatereact-routerto7.9.5andstylelint-scssto6.12.1, respectively.. The changes to other places in the code base outside of these two packages is due to peer dependencies and removing deprecated testing libraries.This PR also addresses this issue