Skip to content

gl: route feathers to atlas on Mali-G52 to avoid PLS corruption #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harrynron wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

gl: route feathers to atlas on Mali-G52 to avoid PLS corruption #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions renderer/src/gl/render_context_gl_impl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,12 +192,13 @@ RenderContextGLImpl::RenderContextGLImpl(
// (5-10%) improvement from not using flat varyings.
m_platformFeatures.avoidFlatVaryings = true;
}
if (m_capabilities.isPowerVR)
if (m_capabilities.isPowerVR || strstr(rendererString, "Mali-G52"))
{
// Vivo Y21 (PowerVR Rogue GE8320; OpenGL ES 3.2 build 1.13@5776728a)
// seems to hit some sort of reset condition that corrupts pixel local
// storage when rendering a complex feather. For now, feather directly
// to the screen on PowerVR; always go offscreen.
// PowerVR (Vivo Y21, Rogue GE8320; OpenGL ES 3.2 build 1.13@5776728a)
// and Mali-G52 (Panfrost, e.g. MediaTek MT8169) hit a reset condition
Copy link
Copy Markdown

@chealy chealy Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should list the specific driver version.

// that corrupts pixel local storage when rendering a complex feather
// directly into PLS. Route feathers through the offscreen atlas on
// these GPUs.
m_platformFeatures.alwaysFeatherToAtlas = true;
}
m_platformFeatures.clipSpaceBottomUp = true;
Expand Down