Skip to content
This repository was archived by the owner on Feb 9, 2022. It is now read-only.

Added support for "messageTypeID = submysterygift" - #353

Open
fmalk wants to merge 10 commits into
robotty:masterfrom
fmalk:master
Open

Added support for "messageTypeID = submysterygift"#353
fmalk wants to merge 10 commits into
robotty:masterfrom
fmalk:master

Conversation

@fmalk

@fmalk fmalk commented Oct 6, 2021

Copy link
Copy Markdown

I started receiving this new kind of UserNoticeMessage and I wanted a method like isSub() et al to deal with this type of message.

So I added a new MassSubgiftUsernoticeMessage, just like other SpecificUsernoticeMessage.

I've added a unit test as well. There's a new eventParam called massGiftCount that should be present.

Comment thread package.json Outdated
Comment thread CHANGELOG.md Outdated
@RAnders00

RAnders00 commented Nov 16, 2021

Copy link
Copy Markdown
Contributor

Hey, the build doesn't pass on this PR because you didn't run the automatic formatter (npm run precommit). Would you mind doing that and pushing the changes, so I can take another look? Thank you!

@fmalk

fmalk commented Nov 18, 2021

Copy link
Copy Markdown
Author

@RAnders00 there you go, it should pass lint tests now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants