Skip to content

Migrate version check#1093

Draft
0xfornax wants to merge 2 commits intomasterfrom
migrate-version-check
Draft

Migrate version check#1093
0xfornax wants to merge 2 commits intomasterfrom
migrate-version-check

Conversation

@0xfornax
Copy link
Copy Markdown
Member

@0xfornax 0xfornax commented May 2, 2026

Closes #1092

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

Coverage Report

@0xfornax 0xfornax force-pushed the migrate-version-check branch from 1bb71cc to f1b3586 Compare May 2, 2026 13:14
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

Coverage Report

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

Coverage Report

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 2, 2026

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/service 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool/node 0.00% (ø)
github.com/rocket-pool/smartnode/rocketpool/node/collectors 0.67% (+0.67%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool-cli/service/service.go 0.00% (ø) 10596 (+798) 0 10596 (+798)
github.com/rocket-pool/smartnode/rocketpool/node/collectors/version-update-collector.go 10.28% (+10.28%) 632 (+632) 65 (+65) 567 (+567) 🎉
github.com/rocket-pool/smartnode/rocketpool/node/metrics-exporter.go 0.00% (ø) 999 (+102) 0 999 (+102)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/rocket-pool/smartnode/rocketpool/node/collectors/version-update-collector_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove rp update tracking from the update tracker script

1 participant