[build] Don't link num anymore in Coq#13007
Merged
coqbot-app[bot] merged 2 commits intorocq-prover:masterfrom Sep 17, 2020
Merged
[build] Don't link num anymore in Coq#13007coqbot-app[bot] merged 2 commits intorocq-prover:masterfrom
num anymore in Coq#13007coqbot-app[bot] merged 2 commits intorocq-prover:masterfrom
Conversation
ejgallego
force-pushed
the
zarith+goodbye_num
branch
from
510267b to
63c5bef
Compare
Contributor
Author
|
Good news, only overlay needed is in unicoq, which should be trivial. @beta-ziliani , why did you use type stats = {
unif_problems : Big_int.big_int;
instantiations : Big_int.big_int
} |
Contributor
|
@ejgallego No, definitively Int64.t should work. I will change it now. Thanks for pointing it. |
Contributor
|
Done! I should have done this a long time ago... Thanks yet again. |
Contributor
Author
|
Thanks to you @beta-ziliani ! |
ejgallego
force-pushed
the
zarith+goodbye_num
branch
2 times, most recently
from
1a72caf to
8f3280d
Compare
Contributor
Author
|
This is ready, CI was green before last rebase so not a big problem expected. |
ejgallego
added
kind: compatibility
vbgl
reviewed
Sep 16, 2020
ejgallego
force-pushed
the
zarith+goodbye_num
branch
from
8f3280d to
493e0aa
Compare
vbgl
approved these changes
Sep 16, 2020
Zimmi48
approved these changes
Sep 16, 2020
ejgallego
force-pushed
the
zarith+goodbye_num
branch
from
493e0aa to
5370889
Compare
ejgallego
force-pushed
the
zarith+goodbye_num
branch
from
5370889 to
071958c
Compare
Zimmi48
reviewed
Sep 17, 2020
After rocq-prover#8743 we don't depend on `num` anymore in the codebase; thus we drop the dependency. This could create problems for plugins relying on this implicit linking.
As suggested in the PR review. Co-authored-by: Jim Fehrle <jim.fehrle@gmail.com>
ejgallego
force-pushed
the
zarith+goodbye_num
branch
from
071958c to
29b8aae
Compare
Member
|
@coqbot: merge now |
Contributor
Author
|
Merci @Zimmi48 |
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
Jan 4, 2024
It has not been required since Coq 8.12, cf rocq-prover/rocq#13007 Closes !57768
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #8743 we don't depend on
numanymore in the codebase; thus wedrop the dependency.
This could create problems for plugins relying on this implicit
linking.