Add Email Routing rule surface#16
Merged
Merged
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Reviewed by grok-code-fast-1:optimized:free · 97,776 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
email.routing_rulecfctl surface for zone Email Routing rulesupsertfrom literal recipient to Email WorkerVerification
jq empty catalog/surfaces.jsonbash -n scripts/cf_inventory_email_routing_rules.sh scripts/cf_mutate_email_routing_rule.sh scripts/lib/cfctl.sh commands/cfctl.sh./scripts/verify_static_contract.sh->static-contract verification passedCF_TOKEN_LANE=global ./cfctl list email.routing_rule --zone adapteros.com --name founders@adapteros.com-> existing rule read successfullyCF_TOKEN_LANE=global ./cfctl apply email.routing_rule upsert --zone adapteros.com --name founders@adapteros.com --service star-maildesk-cf-router --plan-> preview produced a PUT plan, no live mutation performedNotes
This intentionally stops at a previewed Email Routing rule mutation. Do not ack live maildesk routing until the maildesk router forwards/notifies operators or the desk UI is ready to be the primary mailbox surface.