Fix roInteger vs roInt#44
Open
DMarine68 wants to merge 6 commits into
Open
Conversation
- Track timedOut state on request details and expose it on the response object - Replace busy-wait GetMessage() loop with wait(waitMs, port) for efficient polling - Fix cancel_and_return scoping bug (was incorrectly referencing m.cancel_and_return) - Fix indentation on EnableEncodings/RetainBodyOnError calls - Add Cursor rules for BrightScript style and project architecture Made-with: Cursor
Remove the timedOut reset at the top of the retry loop so the flag correctly reflects whether any attempt timed out. Create a fresh roUrlTransfer after AsyncCancel() to prevent "operation in progress" errors on the subsequent retry. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
roInteger doesn't exist. This makes the optional
timeout,retryCount, andcacheSecondsargs useless. This PR changes the type checks to use roInt instead.