Add a view-mode selector to the Roku Device View (WebRTC playback)#833
Draft
chrisdp wants to merge 3 commits into
Draft
Add a view-mode selector to the Roku Device View (WebRTC playback)#833chrisdp wants to merge 3 commits into
chrisdp wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a source-mode selector to the Roku Device View. A dropdown switches the panel between Screenshot (default, unchanged) and live stream/capture modes; more can be added later. Everything runs in the webview, with no extension host changes. The selected mode and a per-mode last-used URL persist in webview storage.
Modes:
<video>, and DELETEs the session on Stop.<video src>for progressive files.<img>multipart/x-mixed-replace.Capability detection
Webview media support varies by platform and Electron build, so on load the panel probes what actually works and only offers supported modes (WebRTC gated on RTCPeerConnection; Video URL kept only if a native container plays). Native
<video>support is measured with a real load-probe (load a tiny embedded clip, watch forloadeddatavserror), becausecanPlayTypereports the codec allowlist without knowing whether the container demuxer is present. The Video URL mode shows the detected support inline.VS Code webview media support (what we measured)
Follow-ups
Authorization: Bearer <streamKey>)