Reuse probed device-info for launch and host selection#839
Open
chrisdp wants to merge 4 commits into
Open
Conversation
promptForHost and manual host entry now return { host, deviceInfo }, using
the raw device-info gathered while probing the device. The debug config
provider attaches that raw device-info to the launch config so the debug
session can skip its own device-info request, and enhances a local copy via
roku-deploy's normalizeDeviceInfo instead of making a second request.
promptForHost and promptForHostManual now resolve to
{ host, deviceInfo } | undefined instead of an object with undefined fields,
so callers get a clear all-or-nothing result. Callers read the host via
optional chaining.
…ail fast when unreachable Add a shared HostWithDeviceInfo interface (host + raw device-info) in the device manager, returned by promptForHost, promptForHostManual, and getHealthyActiveHost. processHostParameter reuses the device already probed by the picker/active-host flow instead of probing again, assigns the raw device-info onto config.deviceInfo, and throws when the device can't be reached. Password resolution reads the serial number from config.deviceInfo, so processHostParameter no longer returns a tuple.
TwitchBronBron
added
the
create-vsix
Contributor
|
Hey there! I just built a new version of the vscode extension based on 2fc7e76. You can downloaded the .vsix here and then follow these installation instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
promptForHost(including manual host entry) now returns{ host, deviceInfo }, using the raw device-info gathered while probing the device. All callers read.host.DebugConfigurationProviderattaches that raw device-info to the launch config so the debug session can skip its owndevice-inforequest, and enhances a local copy via roku-deploy'senhanceDeviceInfoinstead of issuing a second request.Depends on rokucommunity/roku-deploy#300 (
enhanceDeviceInfo) and rokucommunity/roku-debug#381 (the launch configdeviceInfofield).