fix(ui): guard against empty Files slice in buildDownloads#225
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
Skip ROMs whose cached row has has_multiple_files=false and an empty Files slice (and log a warning) instead of indexing g.Files[0]. This panic was reachable when an incremental cache update wrote a row without a files array. Fixes rommapp#223 Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #223.
When the local cache holds a ROM row with
has_multiple_files=falseand an emptyfilesarray (observed after incremental cache updates),buildDownloadsindexedg.Files[0]and panicked withindex out of range [0] with length 0.Skip the entry and log a warning instead. The download manager already tolerates an empty download list, and the user can refresh the library to repopulate file metadata.
Includes a regression test that exercises the empty-Files path and a sanity test for the single-file happy path.