Skip to content

[pcre] download instead of bundle and bump from PCRE_8.43 to PCRE2_10.47#21941

Open
ferdymercury wants to merge 3 commits intoroot-project:masterfrom
ferdymercury:bpcre
Open

[pcre] download instead of bundle and bump from PCRE_8.43 to PCRE2_10.47#21941
ferdymercury wants to merge 3 commits intoroot-project:masterfrom
ferdymercury:bpcre

Conversation

@ferdymercury
Copy link
Copy Markdown
Collaborator

@ferdymercury ferdymercury commented Apr 17, 2026 •
edited
Loading

and lift CMAKE 3.5 policy version

v2 of #21857

ferdymercury and others added 2 commits April 17, 2026 12:05
@ferdymercury
[builtins] download instead of bundle PCRE and bump from PCRE_8.43 to…
0c9615d 
… PCRE2_10.47

and lift CMAKE 3.5 policy version

Delete builtins/pcre/pcre-8.43.tar.bz2

[ci] test builtin_pcre also on Linux

to check no conflicts with system library
as suggested by dpiparo

[cmake] fix library name on non unix

thanks to dpiparo

[cmake] simplify dependency check for pcre2 builtin

matches 6.40 release notes and openssl behavior

[core] depend on builtin
@ferdymercury @hageboeck
[cmake] encapsulate dependency behind CMake target
fa326c3 
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
@ferdymercury ferdymercury mentioned this pull request Apr 17, 2026
Closed
@bellenot
Copy link
Copy Markdown
Member

bellenot commented Apr 17, 2026

It fails on Windows with:

  CMake Error at builtins/pcre/CMakeLists.txt:90 (add_library):
    The target name "PCRE2::PCRE2" is reserved or not valid for certain CMake
    features, such as generator expressions, and may result in undefined
    behavior.
  
  
  CMake Error at builtins/pcre/CMakeLists.txt:91 (target_include_directories):
    Cannot specify include directories for target "PCRE2::PCRE2" which is not
    built by this project.
  
  
  CMake Error at builtins/pcre/CMakeLists.txt:92 (target_link_libraries):
    Cannot specify link libraries for target "PCRE2::PCRE2" which is not built
    by this project.
  
  
  -- Configuring incomplete, errors occurred!

@ferdymercury
Copy link
Copy Markdown
Collaborator Author

ferdymercury commented Apr 17, 2026

It fails on Windows with:

Thanks, should be fixed now.

@ferdymercury ferdymercury marked this pull request as ready for review April 17, 2026 12:33
@ferdymercury ferdymercury requested a review from hageboeck April 17, 2026 12:33
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2026

Test Results

    22 files      22 suites   3d 4h 39m 11s ⏱️
 3 833 tests  3 832 ✅  1 💤 0 ❌
76 552 runs  76 534 ✅ 18 💤 0 ❌

Results for commit c95654b.

@dpiparo dpiparo self-assigned this Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bellenot bellenot Awaiting requested review from bellenot bellenot is a code owner

@dpiparo dpiparo Awaiting requested review from dpiparo dpiparo is a code owner

@hageboeck hageboeck Awaiting requested review from hageboeck

At least 1 approving review is required to merge this pull request.

Assignees

@dpiparo dpiparo

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ferdymercury @bellenot @dpiparo